Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation. (Closed)
Patch Set: PlzNavigate: identify same-page browser-initiated navigation. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 4ecd86acfe5d193b17657f2d080407ce30c033ae..7ff5135a46d297c8c0d79f390ed60e47472a4452 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -1183,6 +1183,12 @@ void FrameLoader::load(const FrameLoadRequest& passedRequest,
return;
}
+ // The navigation has not been detected to be same document. If the request
+ // was declared to be, it means that a renderer-side navigation occurs in
+ // between. In that case, this navigation is dropped.
clamy 2016/12/20 15:16:22 Can you prefix the comment with // PlzNavigate ? I
arthursonzogni 2016/12/21 10:11:08 Done.
+ if (request.resourceRequest().isSameDocumentNavigation())
+ return;
+
startLoad(request, newLoadType, policy);
}

Powered by Google App Engine
This is Rietveld 408576698