Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation. (Closed)
Patch Set: PlzNavigate: identify same-page browser-initiated navigation. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 07fc76005bd703b1b9a19dadc775e921fefab82b..c4dc15a40c6e13cd1dd5cd5c50e177707203db9e 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -2557,6 +2557,7 @@ void RenderFrameHostImpl::CommitNavigation(
DCHECK((response && body.get()) ||
common_params.url.SchemeIs(url::kDataScheme) ||
!ShouldMakeNetworkRequestForURL(common_params.url) ||
+ request_params.is_same_document_navigation ||
IsRendererDebugURL(common_params.url));
UpdatePermissionsForNavigation(common_params, request_params);
@@ -2579,7 +2580,8 @@ void RenderFrameHostImpl::CommitNavigation(
request_params));
// If a network request was made, update the LoFi state.
- if (ShouldMakeNetworkRequestForURL(common_params.url))
+ if (ShouldMakeNetworkRequestForURL(common_params.url) &&
+ !request_params.is_same_document_navigation)
clamy 2016/12/20 15:16:22 Please add curly braces since the if condition spa
arthursonzogni 2016/12/21 10:12:42 Done.
last_navigation_lofi_state_ = common_params.lofi_state;
// TODO(clamy): Release the stream handle once the renderer has finished

Powered by Google App Engine
This is Rietveld 408576698