Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation. (Closed)
Patch Set: Very minor fix. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/frame_host/navigation_controller_impl_unittest.cc ('K') | « content/browser/frame_host/navigation_entry_impl.cc ('k') | content/browser/frame_host/navigation_handle_impl_browsertest.cc » ('j') | content/browser/frame_host/navigation_handle_impl_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index 8ed60813cfc8592fe75bd843f6931c59c078c1ba..c01699d7171eebef5b5b414b22dd18c850ba54a8 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -534,7 +534,8 @@ void NavigationHandleImpl::ReadyToCommitNavigation(
render_frame_host_ = render_frame_host;
state_ = READY_TO_COMMIT;
- if (!IsRendererDebugURL(url_))
+ if (!IsRendererDebugURL(url_) &&
+ !IsSamePage())
nasko 2017/01/13 02:51:10 This should fit just fine on the previous line.
arthursonzogni 2017/01/13 15:18:37 Done.
GetDelegate()->ReadyToCommitNavigation(this);
}
« content/browser/frame_host/navigation_controller_impl_unittest.cc ('K') | « content/browser/frame_host/navigation_entry_impl.cc ('k') | content/browser/frame_host/navigation_handle_impl_browsertest.cc » ('j') | content/browser/frame_host/navigation_handle_impl_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698