Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: content/common/navigation_params.h

Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation. (Closed)
Patch Set: Fix 2 WebContentsImplTest by assigning a document_sequence_number. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 86a5e7e4f6fefd42ce29a05c54d744214e80c0c1..437803a690e142bb6b3e71e6d17827dc3cb5a8d6 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -232,6 +232,7 @@ struct CONTENT_EXPORT RequestNavigationParams {
bool can_load_local_resources,
const PageState& page_state,
int nav_entry_id,
+ bool is_same_document_fragment_change,
nasko 2017/01/10 00:19:00 We are starting to accumulate a bunch of bool para
clamy 2017/01/10 10:52:54 We could also extend the FrameMsg_Navigate_Type::V
arthursonzogni 2017/01/12 17:32:30 It's a good thing to do. I like the idea with Fram
nasko 2017/01/13 02:51:09 Separate commit is definitely a good idea. It will
bool is_same_document_history_load,
bool is_history_navigation_in_new_child,
std::map<std::string, bool> subframe_unique_names,
@@ -269,6 +270,11 @@ struct CONTENT_EXPORT RequestNavigationParams {
// the resulting FrameHostMsg_DidCommitProvisionalLoad message.
int nav_entry_id;
+ // PlzNavigate
+ // Whether this navigation is differing only in the fragment compared to the
+ // current frame's URL. In that case, no network request should be made.
+ bool is_same_document_fragment_change;
+
// For history navigations, this indicates whether the load will stay within
// the same document. Defaults to false.
bool is_same_document_history_load;

Powered by Google App Engine
This is Rietveld 408576698