PlzNavigate: identify same-page browser-initiated navigation.

content/browser/frame_host/navigator_impl.cc

Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 6a8837f474341380d860771385e35677e1c8de65..0ab966f1eecbe555bb9c03815e65608df45075ad 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -422,7 +422,9 @@ bool NavigatorImpl::NavigateToEntry(
               lofi_state, navigation_start),
           entry.ConstructStartNavigationParams(),
           entry.ConstructRequestNavigationParams(
-              frame_entry, is_same_document_history_load,
+              frame_entry,
+              false, // is_same_document_navigation

[nasko, 2017/01/10 00:19:00]

Why are we guaranteed here it isn't same document? Can't the URL we want to go
be just a different fragment from the last committed URL?

[arthursonzogni, 2017/01/12 17:32:30]

You are right. It was something I forgot. I will fix this.
Whatever happens, this attribute is only used with PlzNavigate and we are in a
non-PlzNavigate code. But it's still better to have the correct value or to put
a comment somewhere.

+              is_same_document_history_load,
               is_history_navigation_in_new_child,
               entry.GetSubframeUniqueNames(frame_tree_node),
               frame_tree_node->has_committed_real_load(),