Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: content/test/test_render_frame_host.cc

Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation. (Closed)
Patch Set: Addressed comments(@brettw) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/test_render_frame_host.cc
diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc
index 928e237ab677872d00ae180b27354868f1e2cf68..9e21b1c2192a994cc28d925fcbc420b4f6d2351e 100644
--- a/content/test/test_render_frame_host.cc
+++ b/content/test/test_render_frame_host.cc
@@ -421,6 +421,7 @@ void TestRenderFrameHost::SendRendererInitiatedNavigationRequest(
common_params.url = url;
common_params.referrer = Referrer(GURL(), blink::WebReferrerPolicyDefault);
common_params.transition = ui::PAGE_TRANSITION_LINK;
+ common_params.navigation_type = FrameMsg_Navigate_Type::DIFFERENT_DOCUMENT;
OnBeginNavigation(common_params, begin_params);
}
}
@@ -450,8 +451,10 @@ void TestRenderFrameHost::PrepareForCommitWithServerRedirect(
// PlzNavigate
NavigationRequest* request = frame_tree_node_->navigation_request();
CHECK(request);
- bool have_to_make_network_request = ShouldMakeNetworkRequestForURL(
- request->common_params().url);
+ bool have_to_make_network_request =
+ ShouldMakeNetworkRequestForURL(request->common_params().url) &&
+ !FrameMsg_Navigate_Type::IsSameDocument(
+ request->common_params().navigation_type);
// Simulate a beforeUnload ACK from the renderer if the browser is waiting for
// it. If it runs it will update the request state.

Powered by Google App Engine
This is Rietveld 408576698