ios/web/navigation/navigation_manager_impl.mm - Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/navigation_manager_impl.mm

Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation. (Closed)

Patch Set: Rebase. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/navigation/navigation_manager_impl.mm

diff --git a/ios/web/navigation/navigation_manager_impl.mm b/ios/web/navigation/navigation_manager_impl.mm

index 31a3377b3ade1cfd36a29384fade3e5df96e02c6..2aca9a1a272efb6c96c6a445ca46fbafbb0e4a03 100644

--- a/ios/web/navigation/navigation_manager_impl.mm

+++ b/ios/web/navigation/navigation_manager_impl.mm

@@ -32,10 +32,7 @@ bool AreURLsInPageNavigation(const GURL& existing_url, const GURL& new_url) {

if (existing_url == new_url || !new_url.has_ref())

return false;

- url::Replacements<char> replacements;

- replacements.ClearRef();

- return existing_url.ReplaceComponents(replacements) ==

- new_url.ReplaceComponents(replacements);

+ return GURL::EqualsIgnoringRef(existing_url, new_url);

}

} // anonymous namespace