Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation. (Closed)
Patch Set: Allow renderer-initiated reloads. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
index 5eab8498bb3f0844a30e5d1200af4372cea6f547..17fca07a95cf3a25a3eb5cdb3ae69294e5f7da47 100644
--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
@@ -431,7 +431,7 @@ class RenderFrameHostManagerTest : public RenderViewHostImplTestHarness {
->GetController());
FrameMsg_Navigate_Type::Value navigate_type =
entry.restore_type() == RestoreType::NONE
- ? FrameMsg_Navigate_Type::NORMAL
+ ? FrameMsg_Navigate_Type::DIFFERENT_DOCUMENT
: FrameMsg_Navigate_Type::RESTORE;
std::unique_ptr<NavigationRequest> navigation_request =
NavigationRequest::CreateBrowserInitiated(
@@ -2840,8 +2840,8 @@ TEST_F(RenderFrameHostManagerTestWithBrowserSideNavigation,
NavigationRequest::CreateBrowserInitiated(
contents()->GetFrameTree()->root(), frame_entry->url(),
frame_entry->referrer(), *frame_entry, entry,
- FrameMsg_Navigate_Type::NORMAL, PREVIEWS_UNSPECIFIED, false, false,
- base::TimeTicks::Now(),
+ FrameMsg_Navigate_Type::DIFFERENT_DOCUMENT, PREVIEWS_UNSPECIFIED,
+ false, false, base::TimeTicks::Now(),
static_cast<NavigationControllerImpl*>(&controller()));
manager->DidCreateNavigationRequest(navigation_request.get());
@@ -2901,8 +2901,8 @@ TEST_F(RenderFrameHostManagerTestWithBrowserSideNavigation,
NavigationRequest::CreateBrowserInitiated(
contents()->GetFrameTree()->root(), frame_entry->url(),
frame_entry->referrer(), *frame_entry, entry,
- FrameMsg_Navigate_Type::NORMAL, PREVIEWS_UNSPECIFIED, false, false,
- base::TimeTicks::Now(),
+ FrameMsg_Navigate_Type::DIFFERENT_DOCUMENT, PREVIEWS_UNSPECIFIED,
+ false, false, base::TimeTicks::Now(),
static_cast<NavigationControllerImpl*>(&controller()));
manager->DidCreateNavigationRequest(navigation_request.get());
@@ -2959,8 +2959,8 @@ TEST_F(RenderFrameHostManagerTestWithBrowserSideNavigation,
NavigationRequest::CreateBrowserInitiated(
contents()->GetFrameTree()->root(), frame_entry->url(),
frame_entry->referrer(), *frame_entry, entry,
- FrameMsg_Navigate_Type::NORMAL, PREVIEWS_UNSPECIFIED, false, false,
- base::TimeTicks::Now(),
+ FrameMsg_Navigate_Type::DIFFERENT_DOCUMENT, PREVIEWS_UNSPECIFIED,
+ false, false, base::TimeTicks::Now(),
static_cast<NavigationControllerImpl*>(&controller()));
manager->DidCreateNavigationRequest(navigation_request.get());

Powered by Google App Engine
This is Rietveld 408576698