PlzNavigate: identify same-page browser-initiated navigation.

content/browser/frame_host/navigation_controller_impl_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_controller_impl.h"
 
 #include <stdint.h>
 #include <algorithm>
 #include <utility>
 #include <vector>
@@ skipping 6148 matching lines @@
   web_contents->GetMainFrame()->GetProcess()->AddFilter(filter.get());
 
   // Navigate cross-origin, waiting for the commit to occur.
   UrlCommitObserver cross_origin_commit_observer(root, cross_origin_url);
   UrlCommitObserver history_commit_observer(root, start_url);
   shell()->LoadURL(cross_origin_url);
   cross_origin_commit_observer.Wait();
   EXPECT_EQ(cross_origin_url, web_contents->GetLastCommittedURL());
   EXPECT_EQ(2, web_contents->GetController().GetLastCommittedEntryIndex());
 
-  // Wait for the back navigation to commit as well.
-  history_commit_observer.Wait();
-  EXPECT_EQ(start_url, web_contents->GetLastCommittedURL());
-  EXPECT_EQ(0, web_contents->GetController().GetLastCommittedEntryIndex());
+  if (IsBrowserSideNavigationEnabled()) {
+    // With browser-side-navigation, the history navigation is dropped.
+    // Navigate to another URL to give the back navigation the opportunity to
+    // commit if it was not dropped.
+    GURL another_url(embedded_test_server()->GetURL("b.com", "/title1.html"));

[nasko, 2017/01/19 00:43:35]

Can we use some other way of verifying the navigation was dropped? Doing a new
navigation affects navigation state, so if the browser-side state in
NavigationController is confused because of the dropped history navigation, we
would not be able to detect it this way. I'm not sure what would be a better way
to check as of now, but the fact that the browser doesn't know the history
navigation didn't commit seems problematic, doesn't it?

[arthursonzogni, 2017/01/19 17:49:21]

Being sure that something didn't happens is always harder that being sure that
something happens :-). Adding another navigation is not ideal, but it's the only
thing I could imagine.

[nasko, 2017/01/23 19:10:13]

If we will be performing navigations, let's use a session history navigation,
probably another back navigation to ensure that we didn't confuse browser-side
state by dropping the navigation in the renderer.

[arthursonzogni, 2017/01/24 15:17:04]

Done. Is it what you want?

[nasko, 2017/01/24 16:59:35]

Indeed! Thanks!

+    EXPECT_TRUE(NavigateToURL(shell(), another_url));
+    EXPECT_EQ(3, web_contents->GetController().GetLastCommittedEntryIndex());
+    EXPECT_EQ(4, web_contents->GetController().GetEntryCount());
 
-  // Verify the expected origin through JavaScript. It also has the additional
-  // verification of the process also being still alive.
-  std::string origin;
-  EXPECT_TRUE(ExecuteScriptAndExtractString(
-      web_contents, "domAutomationController.send(document.origin)", &origin));
-  EXPECT_EQ(start_url.GetOrigin().spec(), origin + "/");
+    // Verify the expected origin through JavaScript. It also has the additional
+    // verification of the process also being still alive.
+    std::string origin;
+    EXPECT_TRUE(ExecuteScriptAndExtractString(
+        web_contents, "domAutomationController.send(document.origin)",
+        &origin));
+    EXPECT_EQ(another_url.GetOrigin().spec(), origin + "/");
+  } else {
+    // Wait for the back navigation to commit as well.
+    history_commit_observer.Wait();
+    EXPECT_EQ(start_url, web_contents->GetLastCommittedURL());
+    EXPECT_EQ(0, web_contents->GetController().GetLastCommittedEntryIndex());
+    EXPECT_EQ(3, web_contents->GetController().GetEntryCount());
+
+    // Verify the expected origin through JavaScript. It also has the additional
+    // verification of the process also being still alive.
+    std::string origin;
+    EXPECT_TRUE(ExecuteScriptAndExtractString(
+        web_contents, "domAutomationController.send(document.origin)",
+        &origin));
+    EXPECT_EQ(start_url.GetOrigin().spec(), origin + "/");
+  }
 }
 
 // Test that verifies that Referer and Origin http headers are correctly sent
 // to the final destination of a cross-site POST with a few redirects thrown in.
 // This test is somewhat related to https://crbug.com/635400.
 IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
                        RefererAndOriginHeadersAfterRedirects) {
   // Navigate to the page with form that posts via 307 redirection to
   // |redirect_target_url| (cross-site from |form_url|).  Using 307 (rather than
   // 302) redirection is important to preserve the HTTP method and POST body.
@@ skipping 521 matching lines @@
   NavigationHandleCommitObserver handle_observer(shell()->web_contents(),
                                                  kFragmentURL);
   EXPECT_TRUE(NavigateToURL(shell(), kFragmentURL));
 
   EXPECT_TRUE(handle_observer.has_committed());
   EXPECT_TRUE(handle_observer.was_same_page());
   EXPECT_FALSE(handle_observer.was_renderer_initiated());
 }
 
 }  // namespace content