PlzNavigate: identify same-page browser-initiated navigation.

content/common/navigation_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 214 matching lines @@
 // start a browser-initiated navigation besides those in CommonNavigationParams.
 // PlzNavigate: sent to the renderer to make it issue a stream request for a
 // navigation that is ready to commit.
 struct CONTENT_EXPORT RequestNavigationParams {
   RequestNavigationParams();
   RequestNavigationParams(bool is_overriding_user_agent,
                           const std::vector<GURL>& redirects,
                           bool can_load_local_resources,
                           const PageState& page_state,
                           int nav_entry_id,
+                          bool is_same_document_fragment_change,

[nasko, 2017/01/10 00:19:00]

We are starting to accumulate a bunch of bool params that are all unique and
exclusive. Maybe we should introduce an enum for the navigation type (though bad
name) and avoid having the three separate bool params?

[clamy, 2017/01/10 10:52:54]

We could also extend the FrameMsg_Navigate_Type::Value (and maybe rename it
NavigationType). In that case, we could have the same_document value be a flag
on the type, a bit like we do with TransitionType.

[arthursonzogni, 2017/01/12 17:32:30]

It's a good thing to do. I like the idea with FrameMsg_Navigate_Type. Maybe it
would be better to do a separate commit as there would produce a lot of simple
change in at least 15 files.

[nasko, 2017/01/13 02:51:09]

Separate commit is definitely a good idea. It will also show us whether it is a
good change to make or not, without having a ton of other context.

                           bool is_same_document_history_load,
                           bool is_history_navigation_in_new_child,
                           std::map<std::string, bool> subframe_unique_names,
                           bool has_committed_real_load,
                           bool intended_as_new_entry,
                           int pending_history_list_offset,
                           int current_history_list_offset,
                           int current_history_list_length,
                           bool is_view_source,
                           bool should_clear_history_list,
@@ skipping 17 matching lines @@
 
   // Opaque history state (received by ViewHostMsg_UpdateState).
   PageState page_state;
 
   // For browser-initiated navigations, this is the unique id of the
   // NavigationEntry being navigated to. (For renderer-initiated navigations it
   // is 0.) If the load succeeds, then this nav_entry_id will be reflected in
   // the resulting FrameHostMsg_DidCommitProvisionalLoad message.
   int nav_entry_id;
 
+  // PlzNavigate
+  // Whether this navigation is differing only in the fragment compared to the
+  // current frame's URL. In that case, no network request should be made.
+  bool is_same_document_fragment_change;
+
   // For history navigations, this indicates whether the load will stay within
   // the same document.  Defaults to false.
   bool is_same_document_history_load;
 
   // Whether this is a history navigation in a newly created child frame, in
   // which case the browser process is instructing the renderer process to load
   // a URL from a session history item.  Defaults to false.
   bool is_history_navigation_in_new_child;
 
   // If this is a history navigation, this contains a map of frame unique names
@@ skipping 77 matching lines @@
   ~NavigationParams();
 
   CommonNavigationParams common_params;
   StartNavigationParams start_params;
   RequestNavigationParams request_params;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_NAVIGATION_PARAMS_H_