PlzNavigate: identify same-page browser-initiated navigation.

content/browser/frame_host/navigation_controller_impl_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_controller_impl.h"
 
 #include <stdint.h>
 #include <algorithm>
 #include <utility>
 #include <vector>
@@ skipping 6150 matching lines @@
   // Navigate cross-origin, waiting for the commit to occur.
   UrlCommitObserver cross_origin_commit_observer(root, cross_origin_url);
   UrlCommitObserver history_commit_observer(root, start_url);
   shell()->LoadURL(cross_origin_url);
   cross_origin_commit_observer.Wait();
   EXPECT_EQ(cross_origin_url, web_contents->GetLastCommittedURL());
   EXPECT_EQ(2, web_contents->GetController().GetLastCommittedEntryIndex());
 
   // Wait for the back navigation to commit as well.
   history_commit_observer.Wait();
+
+  // The expected state of the history:
+  //    Without BrowserSideNavigation:
+  //    -> a.com/title1.html
+  //       a.com/title1.html#foo
+  //       suborigin.a.com/title2.html
+  //
+  //    With BrowserSideNavigation:
+  //       a.com/title1.html
+  //       a.com/title1.html#foo
+  //       suborigin.a.com/title2.html
+  //    -> a.com/title1.html

[clamy, 2017/01/09 16:58:48]

Why do we have a different history state in the PlzNavigate case?

[arthursonzogni, 2017/01/12 17:32:29]

The navigation is relaunched from the renderer by putting an
request.setCheckFromBrowserSideNavigation(true);

It doesn't make sense for history-navigation because renderer-side
history-navigation doesn't exists. So it becomes a renderer-side
regular-navigation only.

It's very hard to relaunch the navigation without having problems. It's probably
better to drop the navigation right know such that it resolves the
race-condition quickly in a way we can predict.

   EXPECT_EQ(start_url, web_contents->GetLastCommittedURL());
-  EXPECT_EQ(0, web_contents->GetController().GetLastCommittedEntryIndex());
+  if (IsBrowserSideNavigationEnabled()) {
+    EXPECT_EQ(3, web_contents->GetController().GetLastCommittedEntryIndex());
+    EXPECT_EQ(4, web_contents->GetController().GetEntryCount());
+  }
+  else {
+    EXPECT_EQ(0, web_contents->GetController().GetLastCommittedEntryIndex());
+    EXPECT_EQ(3, web_contents->GetController().GetEntryCount());
+  }
 
   // Verify the expected origin through JavaScript. It also has the additional
   // verification of the process also being still alive.
   std::string origin;
   EXPECT_TRUE(ExecuteScriptAndExtractString(
       web_contents, "domAutomationController.send(document.origin)", &origin));
   EXPECT_EQ(start_url.GetOrigin().spec(), origin + "/");
 }
 
 // Test that verifies that Referer and Origin http headers are correctly sent
@@ skipping 528 matching lines @@
   NavigationHandleCommitObserver handle_observer(shell()->web_contents(),
                                                  kFragmentURL);
   EXPECT_TRUE(NavigateToURL(shell(), kFragmentURL));
 
   EXPECT_TRUE(handle_observer.has_committed());
   EXPECT_TRUE(handle_observer.was_same_page());
   EXPECT_FALSE(handle_observer.was_renderer_initiated());
 }
 
 }  // namespace content