PlzNavigate: identify same-page browser-initiated navigation.

components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/rand_util.h"
 #include "base/time/time.h"
 #include "components/subresource_filter/content/browser/content_subresource_filter_driver.h"
@@ skipping 191 matching lines @@
   CreateDriverForFrameHostIfNeeded(render_frame_host);
 }
 
 void ContentSubresourceFilterDriverFactory::RenderFrameDeleted(
     content::RenderFrameHost* render_frame_host) {
   frame_drivers_.erase(render_frame_host);
 }
 
 void ContentSubresourceFilterDriverFactory::ReadyToCommitNavigation(
     content::NavigationHandle* navigation_handle) {
-  DCHECK(!navigation_handle->IsSamePage());
+  if (navigation_handle->IsSamePage())

[clamy, 2017/01/09 16:58:48]

I don't think we want to call ReadyToCommitNavigation for a same page
navigation.

[arthursonzogni, 2017/01/12 17:32:29]

I don't know. I will filter the call to ReadyToCommitNavigation for the moment
and we will see later what should be done.

[nasko, 2017/01/13 02:51:09]

This means that users of WebContentsObserver will have to account for this
difference in behavior, which might make their code more complex. I wonder what
would be the issue with dispatching ReadyToCommitNavigation for same-page cases?

+    return;
   content::RenderFrameHost* render_frame_host =
       navigation_handle->GetRenderFrameHost();
   GURL url = navigation_handle->GetURL();
   ReadyToCommitNavigationInternal(render_frame_host, url);
 }
 
 void ContentSubresourceFilterDriverFactory::DidFinishLoad(
     content::RenderFrameHost* render_frame_host,
     const GURL& validated_url) {
   if (render_frame_host->GetParent())
@@ skipping 92 matching lines @@
   if (!hits_pattern)
     return;
   UMA_HISTOGRAM_ENUMERATION(
       "SubresourceFilter.PageLoad.RedirectChainMatchPattern", hits_pattern,
       0x10 /* max value */);
   UMA_HISTOGRAM_COUNTS("SubresourceFilter.PageLoad.RedirectChainLength",
                        navigation_chain_.size());
 }
 
 }  // namespace subresource_filter