Issue 258433007: DevTools: Fix a DCHECK failure during browser shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258433007: DevTools: Fix a DCHECK failure during browser shutdown. (Closed)

Created:
6 years, 8 months ago by babu

Modified:
6 years, 8 months ago

Reviewers:
Vladislav Kaznacheev, pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

DevTools: Fix a DCHECK failure during browser shutdown. Call StopListening() during the Shutdown phase instead of calling it in the destructor. This fixes a DCHECK failure during browser shutdown when the PortForwardingController tries to access a BrowserContext that's been destroyed. BUG=366698 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266100

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/devtools/device/port_forwarding_controller.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/devtools/device/port_forwarding_controller.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/258433007/1

6 years, 8 months ago (2014-04-24 21:49:10 UTC) #4

Message was sent while issue was closed.

Change committed as 266100

Expand Messages | Collapse Messages