Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: build/common.gypi

Issue 258433005: Remove {linux|android}_use_tcmalloc and switch to use_allocator in Chromium. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gyp ('k') | build/gyp_chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 85992cec27bbe48dc15937a1100386d8c2246bc1..de8f2b526a34da2974ecc41a144151d875c91e6d 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -811,10 +811,7 @@
['OS=="linux" and target_arch=="arm" and chromeos==0', {
# Set some defaults for arm/linux chrome builds
- # TODO(dmikurube): Change the default of use_allocator to "none".
- # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554
- 'linux_use_tcmalloc%': 0,
- 'use_allocator%': 'see_use_tcmalloc',
+ 'use_allocator%': 'none',
# sysroot needs to be an absolute path otherwise it generates
# incorrect results when passed to pkg-config
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/arm-sysroot',
@@ -1211,15 +1208,8 @@
'binutils_dir%': '',
# Enable TCMalloc.
- # TODO(dmikurube): Change Linux default of use_allocator to "tcmalloc".
- # TODO(dmikurube): Change Android default of use_allocator to "none".
- # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/345554
- # {linux|android}_use_tcmalloc are to be replaced with use_allocator.
- # They are now used only if use_allocator=="see_use_tcmalloc" (default).
- # TODO(dmikurube): Assert when {linux|android}_use_tcmalloc is explicitly specified.
- 'linux_use_tcmalloc%': 1,
- 'android_use_tcmalloc%': 0,
- 'use_allocator%': 'see_use_tcmalloc',
+ # Default of 'use_allocator' is set to 'none' if OS=='android' later.
+ 'use_allocator%': 'tcmalloc',
# Set to 1 to link against libgnome-keyring instead of using dlopen().
'linux_link_gnome_keyring%': 0,
@@ -1449,10 +1439,7 @@
'werror%': '',
'disable_nacl%': 1,
'nacl_untrusted_build%': 0,
- # TODO(dmikurube): Change the default of use_allocator to "none".
- # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554
- 'linux_use_tcmalloc%': 0,
- 'use_allocator%': 'see_use_tcmalloc',
+ 'use_allocator%': 'none',
}],
['OS=="linux" and target_arch=="mipsel"', {
'sysroot%': '<(sysroot)',
@@ -1639,10 +1626,7 @@
'input_speech%': 0,
'java_bridge%': 1,
'build_ffmpegsumo%': 0,
- # TODO(dmikurube): Change the default of use_allocator to "none".
- # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554
- 'linux_use_tcmalloc%': 0,
- 'use_allocator%': 'see_use_tcmalloc',
+ 'use_allocator%': 'none',
# Disable Native Client.
'disable_nacl%': 1,
@@ -2026,10 +2010,7 @@
'win_release_InlineFunctionExpansion': '0',
'win_release_OmitFramePointers': '0',
- # TODO(dmikurube): Change the default of use_allocator to "tcmalloc".
- # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554
- 'linux_use_tcmalloc%': 1,
- 'use_allocator': 'see_use_tcmalloc',
+ 'use_allocator': 'tcmalloc',
'release_valgrind_build': 1,
'werror': '',
'component': 'static_library',
@@ -2282,8 +2263,7 @@
'<(DEPTH)/build/mac/asan.gyp:asan_dynamic_runtime',
],
}],
- # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554
- ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)) and clang_type_profiler==1', {
+ ['OS=="linux" and use_allocator!="none" and clang_type_profiler==1', {
'cflags_cc!': ['-fno-rtti'],
'cflags_cc+': [
'-frtti',
@@ -3851,8 +3831,7 @@
}],
],
}],
- # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/345554
- ['use_allocator!="tcmalloc" and (use_allocator!="see_use_tcmalloc" or ((OS=="linux" and linux_use_tcmalloc==0) or (OS=="android" and android_use_tcmalloc==0)))', {
+ ['use_allocator!="tcmalloc"', {
'defines': ['NO_TCMALLOC'],
}],
['linux_use_gold_flags==1', {
« no previous file with comments | « base/base.gyp ('k') | build/gyp_chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698