DDC/AnalyzerCLI common cmdline option processing

DDC/AnalyzerCLI common cmdline option processing

Refactor DDC and Analyzer CLI command line option processing
to use common createContextBuilderOptions method
and ContextBuilderOptions to hold common options.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/13bd1ad0bfd738d68afba2c2ec74d92ce992af5e

[danrubel, 2016-12-19 17:26:31]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com, jmesserly@google.com, vsm@google.com

[Brian Wilkerson, 2016-12-19 17:45:36]

lgtm

https://codereview.chromium.org/2584293003/diff/1/pkg/analyzer/lib/src/comman...
File pkg/analyzer/lib/src/command_line/arguments.dart (right):

https://codereview.chromium.org/2584293003/diff/1/pkg/analyzer/lib/src/comman...
pkg/analyzer/lib/src/command_line/arguments.dart:107: void
defineAnalysisArguments(ArgParser parser, {bool hide: true, ddc: false}) {
'ddc' --> 'bool ddc'

I'm not fond of the client-specific argument. Hopefully we can remove it in the
future and/or replace it by something more semantically meaningful.

https://codereview.chromium.org/2584293003/diff/1/pkg/analyzer/lib/src/comman...
pkg/analyzer/lib/src/command_line/arguments.dart:132: help: 'Enable strong
static checks (https://goo.gl/DqcBsw)', hide: ddc);
I think this needs to include 'defaultsTo: ddc,'.

[danrubel, 2016-12-19 21:21:17]

https://codereview.chromium.org/2584293003/diff/1/pkg/analyzer/lib/src/comman...
File pkg/analyzer/lib/src/command_line/arguments.dart (right):

https://codereview.chromium.org/2584293003/diff/1/pkg/analyzer/lib/src/comman...
pkg/analyzer/lib/src/command_line/arguments.dart:107: void
defineAnalysisArguments(ArgParser parser, {bool hide: true, ddc: false}) {
On 2016/12/19 17:45:36, Brian Wilkerson wrote:
> 'ddc' --> 'bool ddc'
> 
> I'm not fond of the client-specific argument. Hopefully we can remove it in
the
> future and/or replace it by something more semantically meaningful.

Yes, this is temporary until I can normalize DDC options with Analyzer CLI.

Oops... the TODO comment in the defineDDCAnalysisArguments option should have
been moved here.
Done.

https://codereview.chromium.org/2584293003/diff/1/pkg/analyzer/lib/src/comman...
pkg/analyzer/lib/src/command_line/arguments.dart:132: help: 'Enable strong
static checks (https://goo.gl/DqcBsw)', hide: ddc);
On 2016/12/19 17:45:36, Brian Wilkerson wrote:
> I think this needs to include 'defaultsTo: ddc,'.

Good point. Done.

[danrubel, 2016-12-19 21:24:26]

Description was changed from

==========
DDC/AnalyzerCLI common cmdline option processing

Refactor DDC and Analyzer CLI command line option processing
to use common createContextBuilderOptions method
and ContextBuilderOptions to hold common options.
==========

to

==========
DDC/AnalyzerCLI common cmdline option processing

Refactor DDC and Analyzer CLI command line option processing
to use common createContextBuilderOptions method
and ContextBuilderOptions to hold common options.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/13bd1ad0bfd738d68afba2c2ec74d92ce992af5e
==========

[danrubel, 2016-12-19 21:24:28]

Committed patchset #3 (id:40001) manually as
13bd1ad0bfd738d68afba2c2ec74d92ce992af5e (presubmit successful).