Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/Database.cpp

Issue 2584263002: Specify TaskType of posted Task explicitly in WebSQL (9) (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webdatabase/Database.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/Database.cpp b/third_party/WebKit/Source/modules/webdatabase/Database.cpp
index 45bd182b122121d6d23385a6c880162abf184b4b..e667ecff0d6225ab310bf3e6a4b6de4e022e3ba7 100644
--- a/third_party/WebKit/Source/modules/webdatabase/Database.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/Database.cpp
@@ -28,6 +28,7 @@
#include "core/dom/ExceptionCode.h"
#include "core/dom/ExecutionContext.h"
#include "core/dom/ExecutionContextTask.h"
+#include "core/dom/TaskRunnerHelper.h"
#include "core/html/VoidCallback.h"
#include "core/inspector/ConsoleMessage.h"
#include "modules/webdatabase/ChangeVersionData.h"
@@ -873,9 +874,10 @@ void Database::runTransaction(SQLTransactionCallback* callback,
std::unique_ptr<SQLErrorData> error = SQLErrorData::create(
SQLError::kUnknownErr, "database has been closed");
getExecutionContext()->postTask(
- BLINK_FROM_HERE, createSameThreadTask(&callTransactionErrorCallback,
- wrapPersistent(callback),
- WTF::passed(std::move(error))));
+ TaskType::DatabaseAccess, BLINK_FROM_HERE,
+ createSameThreadTask(&callTransactionErrorCallback,
+ wrapPersistent(callback),
+ WTF::passed(std::move(error))));
}
}
}
@@ -884,7 +886,7 @@ void Database::scheduleTransactionCallback(SQLTransaction* transaction) {
// The task is constructed in a database thread, and destructed in the
// context thread.
getExecutionContext()->postTask(
- BLINK_FROM_HERE,
+ TaskType::DatabaseAccess, BLINK_FROM_HERE,
createCrossThreadTask(&SQLTransaction::performPendingCallback,
wrapCrossThreadPersistent(transaction)));
}

Powered by Google App Engine
This is Rietveld 408576698