VM: Fix bug with evaluation order of static setter invocation.

runtime/vm/parser.cc

Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc	(revision 28210)
+++ runtime/vm/parser.cc	(working copy)
@@ -8136,7 +8136,7 @@
                                     NULL,
                                     false,
                                     Class::ZoneHandle(cls.raw()),
-                                    String::ZoneHandle(field_name.raw()));
+                                    field_name);

[Florian Schneider, 2013/10/03 15:33:22]

field_name is already a ZoneHandle.

     } else {
       // Field exists.
       if (field.is_final()) {
@@ -8206,13 +8206,11 @@
     String& name = String::CheckedZoneHandle(primary->primary().raw());
     if (current_function().is_static() ||
         current_function().IsInFactoryScope()) {
-      return ThrowNoSuchMethodError(primary->token_pos(),
-                                    current_class(),
-                                    name,
-                                    NULL,  // No arguments.
-                                    InvocationMirror::kStatic,

[Ivan Posva, 2013/10/03 16:44:05]

You are losing information here about the kind of NoSuchMethod. Why don't we
just pass the arguments here?

[Florian Schneider, 2013/10/04 09:10:28]

We would need the RHS of the assignment as arguments here. I think this would be
a bigger change to the parser.

Actually, the contrary is the case: Here we don't know if it will be a getter or
setter. Later, the StaticGetterNode is transformed into StaticSetterNode if it
occurs in an assignment. As a result, the error message is more precise with my
change: It include the arguments and distinguishes between getter and setter.

Before:
No top-level getter or setter 'unknown' declared.

NoSuchMethodError : method not found: 'unknown'
Receiver: top-level
Arguments: [...]


After:
No top-level setter 'set:unknown' declared.

NoSuchMethodError : method not found: 'set:unknown'
Receiver: top-level
Arguments: [null]

-                                    InvocationMirror::kField,
-                                    NULL);  // No existing function.
+      return new StaticGetterNode(primary->token_pos(),
+                                  NULL,  // No receiver.
+                                  false,  // Not a super getter.
+                                  Class::ZoneHandle(current_class().raw()),
+                                  name);
     } else {
       AstNode* receiver = LoadReceiver(primary->token_pos());
       return CallGetter(node->token_pos(), receiver, name);