Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.h

Issue 2584143003: Repeat footers in paginated context (Closed)
Patch Set: bug 656232 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTable.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.h b/third_party/WebKit/Source/core/layout/LayoutTable.h
index 6e963244601215b634fde19e86d7775af3b105e7..4135263d60968673c1901fba0be5e783f533d052 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTable.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTable.h
@@ -213,8 +213,7 @@ class CORE_EXPORT LayoutTable final : public LayoutBlock {
}
LayoutTableSection* Header() const {
- // TODO(mstensho): We should ideally DCHECK(!needsSectionRecalc()) here, but
- // we currently cannot, due to crbug.com/693212
+ DCHECK(!NeedsSectionRecalc());
mstensho (USE GERRIT) 2017/06/16 08:43:06 Better leave this alone in this CL. I don't even k
rhogan 2017/06/20 18:46:05 OK.
return head_;
}
LayoutTableSection* Footer() const {
@@ -233,6 +232,13 @@ class CORE_EXPORT LayoutTable final : public LayoutBlock {
return row_offset_from_repeating_header_;
}
+ void SetRowOffsetFromRepeatingFooter(LayoutUnit offset) {
+ row_offset_from_repeating_footer_ = offset;
+ }
+ LayoutUnit RowOffsetFromRepeatingFooter() const {
+ return row_offset_from_repeating_footer_;
+ }
+
// These functions return nullptr if the table has no sections.
LayoutTableSection* TopSection() const;
LayoutTableSection* BottomSection() const;
@@ -582,6 +588,7 @@ class CORE_EXPORT LayoutTable final : public LayoutBlock {
LayoutUnit block_offset_to_first_repeatable_header_;
LayoutUnit row_offset_from_repeating_header_;
+ LayoutUnit row_offset_from_repeating_footer_;
LayoutUnit old_available_logical_height_;
};

Powered by Google App Engine
This is Rietveld 408576698