Repeat footers in paginated context

third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
index 476208fca2f92c27eba76c522faa3754e738b95a..4899439a76c88938f020ee90057126b2a5c20d9a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
@@ -1138,8 +1138,10 @@ void LayoutBlockFlow::AdjustLinePositionForPagination(RootInlineBox& line_box,
   LayoutUnit page_logical_height = PageLogicalHeightForOffset(logical_offset);
   LayoutUnit remaining_logical_height = PageRemainingLogicalHeightForOffset(
       logical_offset, kAssociateWithLatterPage);
+  LayoutUnit remaining_logical_height_including_footer =
+      remaining_logical_height - layout_state->HeightOffsetForTableFooters();

[mstensho (USE GERRIT), 2017/06/16 08:43:05]

Isn't this something that belongs inside PageRemainingLogicalHeightForOffset()?
Who would want to ignore footers?

[rhogan, 2017/06/20 18:46:05]

I've explained why I think this is the way to do it in a new comment.

   int line_index = LineCount(&line_box);
-  if (remaining_logical_height < line_height ||
+  if (remaining_logical_height_including_footer < line_height ||
       (ShouldBreakAtLineToAvoidWidow() &&
        LineBreakToAvoidWidow() == line_index)) {
     LayoutUnit pagination_strut = CalculatePaginationStrutToFitContent(