Repeat footers in paginated context

third_party/WebKit/Source/core/layout/LayoutTable.h

Index: third_party/WebKit/Source/core/layout/LayoutTable.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.h b/third_party/WebKit/Source/core/layout/LayoutTable.h
index fe3b67a627df9896665cbefbcc1bc8c538635182..43f2db9316d80b8894f7f1776c849cd82d01d192 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTable.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTable.h
@@ -253,6 +253,17 @@ class CORE_EXPORT LayoutTable final : public LayoutBlock {
     effective_column_positions_[index] = position;
   }
 
+  void SetPositionOfRepeatingFooterGroupOnPage(int page, LayoutUnit position) {

[mstensho (USE GERRIT), 2017/05/08 13:55:59]

Could you document here that |page| is the page number relatively to the page
where the table starts - NOT the overall page number?

[rhogan, 2017/05/09 19:57:15]

Done.

+    position_of_repeating_footer_group_on_page_.Grow(page + 1);

[mstensho (USE GERRIT), 2017/05/08 13:55:59]

Grow() requires that you're actually requesting growth, and it seems that
there's no guarantee that page+1 is larger than the current size of the vector,
since nobody resets it at the beginning of layout, so that a subsequent layout
is bound to hit the DCHECK_GE failure in Vector::Grow().

[rhogan, 2017/05/09 19:57:15]

Done.

+    position_of_repeating_footer_group_on_page_[page] = position;
+  }
+  const LayoutUnit GetPositionOfRepeatingFooterGroupOnPage(int page) const {
+    return position_of_repeating_footer_group_on_page_[page];
+  }
+  const Vector<LayoutUnit>& PositionOfRepeatingFooterGroupOnPage() const {
+    return position_of_repeating_footer_group_on_page_;
+  }
+
   LayoutTableSection* Header() const {
     // TODO(mstensho): We should ideally DCHECK(!needsSectionRecalc()) here, but
     // we currently cannot, due to crbug.com/693212
@@ -445,7 +456,7 @@ class CORE_EXPORT LayoutTable final : public LayoutBlock {
 
   void PaintMask(const PaintInfo&, const LayoutPoint&) const final;
 
-  void SubtractCaptionRect(LayoutRect&) const;
+  void SubtractCaptionRect(LayoutRect&, bool after_only = false) const;
 
   bool IsLogicalWidthAuto() const;
 
@@ -555,6 +566,8 @@ class CORE_EXPORT LayoutTable final : public LayoutBlock {
   // numEffectiveColumns() + 1.
   mutable Vector<int> effective_column_positions_;
 
+  mutable Vector<LayoutUnit> position_of_repeating_footer_group_on_page_;

[mstensho (USE GERRIT), 2017/05/08 13:55:59]

Are you sure you shouldn't use <int> here? Tables don't really deal a lot with
subpixels. Also, this should probably be a typedef, since you need it for
PositionOfRepeatingFooterGroupOnPage() as well.

[rhogan, 2017/05/09 19:57:15]

The row's logical top is stored as a LayoutUnit so it makes sense to me to store
it without converting it.

+
   // The captions associated with this object.
   mutable Vector<LayoutTableCaption*> captions_;