third_party/WebKit/LayoutTests/fast/multicol/balance-repeating-table-headers.html - Issue 2584143003: Repeat footers in paginated context

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/balance-repeating-table-headers.html

Issue 2584143003: Repeat footers in paginated context (Closed)

Patch Set: bug 656232 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fragmentation/single-line-cells-multiple-tables-caption-repeating-thead-tfoot-with-border-spacing-at-top-of-row.html » ('j') | third_party/WebKit/Source/core/layout/LayoutTable.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <p>There should be a yellow/hotpink square 2x2 chessboard below.</p>	2 <p>There should be a yellow/hotpink square 2x2 chessboard below.</p>

3 <div style="columns:3; column-gap:0; width:60px; line-height:20px; orphans:1; wi dows:1;">	3 <div style="columns:3; column-gap:0; width:60px; line-height:20px; orphans:1; wi dows:1;">

4 <div style="background:yellow;"><br></div>	4 <div style="background:yellow;"><br></div>

5 <table cellspacing="0" cellpadding="0" style="width:40px;">	5 <table cellspacing="0" cellpadding="0" style="width:40px;">

6 <!-- The thead should be repeated at the top of each column	6 <!-- The thead should be repeated at the top of each column

7 that the table breaks into. -->	7 that the table breaks into. -->

8 <thead style="break-inside:avoid;">	8 <thead style="break-inside:avoid;">

9 <tr>	9 <tr>

10 <td style="background:hotpink;"><br></td>	10 <td style="background:hotpink;"><br></td>

11 </tr>	11 </tr>

12 </thead>	12 </thead>

13 <tbody>	13 <tbody>

14 <tr>	14 <tr>

15 <td><br></td>	15 <td><br></td>

16 </tr>	16 </tr>

17 <tr>	17 <tr>

	18 <td><br></td>

	19 </tr>
	mstensho (USE GERRIT) 2017/05/08 13:55:58 Why changes here? No repeating footers here. Why changes here? No repeating footers here. rhogan 2017/05/09 19:57:15 This is so that the header is < 25% of the table. Show quoted text On 2017/05/08 at 13:55:58, mstensho wrote: > Why changes here? No repeating footers here. This is so that the header is < 25% of the table. mstensho (USE GERRIT) 2017/05/10 10:59:03 If it's not feasible to break out this change from Show quoted text On 2017/05/09 19:57:15, rhogan wrote: > On 2017/05/08 at 13:55:58, mstensho wrote: > > Why changes here? No repeating footers here. > > This is so that the header is < 25% of the table. If it's not feasible to break out this change from this CL (I'd prefer that), please mention this change in the commit comment.
	20 <tr>

	21 <td><br></td>

	22 </tr>

	23 <tr>

18 <td style="background:yellow;"><br></td>	24 <td style="background:yellow;"><br></td>

19 </tr>	25 </tr>

20 <tr>	26 <tr>

21 <td><br></td>	27 <td><br></td>

22 </tr>	28 </tr>

	29 <tr>

	30 <td><br></td>

	31 </tr>

	32 <tr>

	33 <td><br></td>

	34 </tr>

23 </tbody>	35 </tbody>

24 </table>	36 </table>

25 <br>	37 <br>

26 <br>	38 <br>

27 <br>	39 <br>

28 </div>	40 </div>

OLD	NEW