content/shell/browser/shell_gtk.cc - Issue 25841002: Don't crash on invalid URL in GTK ContentShell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_gtk.cc

Issue 25841002: Don't crash on invalid URL in GTK ContentShell (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: url was already a GURL Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/shell_gtk.cc

diff --git a/content/shell/browser/shell_gtk.cc b/content/shell/browser/shell_gtk.cc

index a06a6a036f809049ec5b3b45042d91269f008ae4..3cc71f716683492552c49ddd843d4ed2550d2ca9 100644

--- a/content/shell/browser/shell_gtk.cc

+++ b/content/shell/browser/shell_gtk.cc

@@ -281,7 +281,8 @@ void Shell::OnURLEntryActivate(GtkWidget* entry) {

GURL url(str);

if (!url.has_scheme())

url = GURL(std::string("http://") + std::string(str));

- LoadURL(GURL(url));

+ if (url.is_valid())

+ LoadURL(url);

}

// Callback for when the main window is destroyed.

« no previous file with comments | « no previous file | no next file » | no next file with comments »