Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 25841002: Don't crash on invalid URL in GTK ContentShell (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Don't crash on invalid URL in GTK ContentShell Entering an invalid URL crashed on the failing DCHECK in GURL::spec(). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226715

Patch Set 1 #

Patch Set 2 : url was already a GURL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/shell/browser/shell_gtk.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
Jochen, I emailed Elliot about this quickfix yesterday and he thought it would be OK, ...
7 years, 2 months ago (2013-10-03 06:30:00 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 2 months ago (2013-10-03 06:44:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/25841002/4001
7 years, 2 months ago (2013-10-03 06:45:30 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-03 08:40:35 UTC) #4
Message was sent while issue was closed.
Change committed as 226715

Powered by Google App Engine
This is Rietveld 408576698