Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

Issue 2583993002: [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for 'beforeinput' (1/3) (Closed)
Patch Set: Add TODO, remove |willApply()| Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
index f2d7317eeca7d2291063530eaefa637e55976300..54ca077d5db6597c4bd1d754a03742399a707923 100644
--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
@@ -118,6 +118,15 @@ class CORE_EXPORT CompositeEditCommand : public EditCommand {
protected:
explicit CompositeEditCommand(Document&);
+ // TODO(chongz): Implement "beforeinput" as described below:
+ // Fires "beforeinput" and will return |false| to cancel applying editing if
+ // * "beforeinput" was canceled, or
+ // * |frame| was destroyed by event handlers.
+ // |willApplyEditing()| should be called from
+ // * |CompositeEditCommand::apply()|, and
+ // * |TypingCommand::willAddTypingToOpenCommand()|.
+ bool willApplyEditing(EditCommandSource);
+
//
// sugary-sweet convenience functions to help create and apply edit commands
// in composite commands
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698