Replace deprecated Android java test annotations

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
@@ skipping 1703 matching lines @@
         util_log_errors))
 
   if tag_with_dot_errors:
     results.append(output_api.PresubmitPromptWarning(
         'Dot in log tags cause them to be elided in crash reports.\n' + REF_MSG,
         tag_with_dot_errors))
 
   return results
 
 
+def _CheckAndroidTestAnnotationUsage(input_api, output_api):
+  """Check that the deprecated test annotations like, "Smoke"

[jbudorick, 2016/12/20 00:22:19]

nit:

"""Checks that android.test.suitebuilder.annotation.* is no longer used."""

+     "android.test.suitebuilder.annotation.SmallTest", should no longer be used
+  """
+  deprecated_annotation_import_pattern = input_api.re.compile(
+      r'^import android\.test\.suitebuilder\.annotation\..*;',
+      input_api.re.MULTILINE)
+  sources = lambda x: input_api.FilterSourceFile(x, white_list=(r'.*\.java$',),

[jbudorick, 2016/12/20 00:22:19]

nit: drop all params onto the following line.

+      black_list=None)
+  errors = []
+  for f in input_api.AffectedFiles(sources):
+    for line_num, line in f.ChangedContents():
+      if deprecated_annotation_import_pattern.search(line):
+        errors.append("%s:%d" % (f.LocalPath(), line_num))
+
+  results = []
+  if errors:
+    results.append(output_api.PresubmitError(
+      'Annotations in android.test.suitebuilder.annotation is deprecated since'

[jbudorick, 2016/12/20 00:22:19]

nit:

Annotations in android.test.suitebuilder.annotation have been deprecated since
API level 24. Please use android.support.test.filters  from
//third_party/android_support_test_runner:runner_java instead. Contact
yolandyan@chromium.org if you have any questions.

+      ' level 24, please replace the annotation with'
+      ' classes in android.support.test.filters. Import'
+      ' "//third_party/android_support_test_runner:runner_java" in your BUILD'
+      ' file if neccessary. Contact yolandyan@chromium.org is you have any'
+      ' questions',
+      errors))
+  return results
+
+
 def _CheckAndroidNewMdpiAssetLocation(input_api, output_api):
   """Checks if MDPI assets are placed in a correct directory."""
   file_filter = lambda f: (f.LocalPath().endswith('.png') and
                            ('/res/drawable/' in f.LocalPath() or
                             '/res/drawable-ldrtl/' in f.LocalPath()))
   errors = []
   for f in input_api.AffectedFiles(include_deletes=False,
                                    file_filter=file_filter):
     errors.append('    %s' % f.LocalPath())
 
@@ skipping 257 matching lines @@
 https://chromium.googlesource.com/chromium/src/+/master/docs/es6_chromium.md#Arrow-Functions
 """ % "\n".join("  %s:%d\n" % line for line in arrow_lines))]
 
 
 def _AndroidSpecificOnUploadChecks(input_api, output_api):
   """Groups checks that target android code."""
   results = []
   results.extend(_CheckAndroidCrLogUsage(input_api, output_api))
   results.extend(_CheckAndroidNewMdpiAssetLocation(input_api, output_api))
   results.extend(_CheckAndroidToastUsage(input_api, output_api))
+  results.extend(_CheckAndroidTestAnnotationUsage(input_api, output_api))
   return results
 
 
 def _CommonChecks(input_api, output_api):
   """Checks common to both upload and commit."""
   results = []
   results.extend(input_api.canned_checks.PanProjectChecks(
       input_api, output_api,
       excluded_paths=_EXCLUDED_PATHS))
   results.extend(
@@ skipping 287 matching lines @@
   results.extend(input_api.canned_checks.CheckTreeIsOpen(
       input_api,
       output_api,
       json_url='http://chromium-status.appspot.com/current?format=json'))
 
   results.extend(input_api.canned_checks.CheckChangeHasBugField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasDescription(
       input_api, output_api))
   return results