Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2583873002: Correctly update the popup window position (Closed)
Patch Set: test added Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 17b34eb542e63671df6b13eacc138b68f475534b..e3c7534999d97def233b2f810103fa9028604334 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -581,6 +581,10 @@ void RenderWidgetHostViewAura::Hide() {
#endif
}
+aura::Window* RenderWidgetHostViewAura::GetToplevelWindow() {
+ return window_->GetToplevelWindow();
+}
+
void RenderWidgetHostViewAura::SetSize(const gfx::Size& size) {
// For a SetSize operation, we don't care what coordinate system the origin
// of the window is in, it's only important to make sure that the origin
@@ -589,21 +593,12 @@ void RenderWidgetHostViewAura::SetSize(const gfx::Size& size) {
}
void RenderWidgetHostViewAura::SetBounds(const gfx::Rect& rect) {
- gfx::Point relative_origin(rect.origin());
-
- // RenderWidgetHostViewAura::SetBounds() takes screen coordinates, but
- // Window::SetBounds() takes parent coordinates, so do the conversion here.
- aura::Window* root = window_->GetRootWindow();
- if (root) {
- aura::client::ScreenPositionClient* screen_position_client =
- aura::client::GetScreenPositionClient(root);
- if (screen_position_client) {
- screen_position_client->ConvertPointFromScreen(
- window_->parent(), &relative_origin);
- }
- }
-
- InternalSetBounds(gfx::Rect(relative_origin, rect.size()));
+ display::Display display =
+ popup_parent_host_view_
+ ? display::Screen::GetScreen()->GetDisplayNearestWindow(
+ popup_parent_host_view_->window_)
+ : display::Screen::GetScreen()->GetDisplayMatching(rect);
+ GetToplevelWindow()->SetBoundsInScreen(rect, display);
}
gfx::Vector2dF RenderWidgetHostViewAura::GetLastScrollOffset() const {

Powered by Google App Engine
This is Rietveld 408576698