Correctly update the popup window position

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include <set>
 #include <utility>
 
 #include "base/auto_reset.h"
@@ skipping 574 matching lines @@
     }
 #endif
   }
 
 #if defined(OS_WIN)
   if (legacy_render_widget_host_HWND_)
     legacy_render_widget_host_HWND_->Hide();
 #endif
 }
 
+aura::Window* RenderWidgetHostViewAura::GetToplevelWindow() {
+  base::debug::StackTrace().Print();
+#if defined(OS_CHROMEOS)
+  return window_->GetToplevelWindow();

[sadrul, 2016/12/16 20:15:44]

On non-chromeos, I assume this returns the
|DesktopNativeWidgetAura::content_window_|? Is there a reason setting the bounds
on that does not work? (because it looks like setting the bounds on
|content_window_| should notify the DesktopWindowTreeHost, which should resize
the Widget too?)

+#else
+  return window_->GetRootWindow();
+#endif
+}
+
 void RenderWidgetHostViewAura::SetSize(const gfx::Size& size) {
   // For a SetSize operation, we don't care what coordinate system the origin
   // of the window is in, it's only important to make sure that the origin
   // remains constant after the operation.
   InternalSetBounds(gfx::Rect(window_->bounds().origin(), size));
 }
 
 void RenderWidgetHostViewAura::SetBounds(const gfx::Rect& rect) {
-  gfx::Point relative_origin(rect.origin());
-
-  // RenderWidgetHostViewAura::SetBounds() takes screen coordinates, but
-  // Window::SetBounds() takes parent coordinates, so do the conversion here.
-  aura::Window* root = window_->GetRootWindow();
-  if (root) {
-    aura::client::ScreenPositionClient* screen_position_client =
-        aura::client::GetScreenPositionClient(root);
-    if (screen_position_client) {
-      screen_position_client->ConvertPointFromScreen(
-          window_->parent(), &relative_origin);
-    }
-  }
-
-  InternalSetBounds(gfx::Rect(relative_origin, rect.size()));
+  display::Display display =
+      popup_parent_host_view_
+          ? display::Screen::GetScreen()->GetDisplayNearestWindow(
+                popup_parent_host_view_->window_)
+          : display::Screen::GetScreen()->GetDisplayMatching(rect);
+  GetToplevelWindow()->SetBoundsInScreen(rect, display);
 }
 
 gfx::Vector2dF RenderWidgetHostViewAura::GetLastScrollOffset() const {
   return last_scroll_offset_;
 }
 
 gfx::NativeView RenderWidgetHostViewAura::GetNativeView() const {
   return window_;
 }
 
@@ skipping 1759 matching lines @@
 
 void RenderWidgetHostViewAura::SetPopupChild(
     RenderWidgetHostViewAura* popup_child_host_view) {
   popup_child_host_view_ = popup_child_host_view;
   event_handler_->SetPopupChild(
       popup_child_host_view,
       popup_child_host_view ? popup_child_host_view->event_handler() : nullptr);
 }
 
 }  // namespace content