[chrome.dial] Adds chrome.dial.fetchDeviceDecription API.

chrome/browser/extensions/api/dial/dial_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "build/build_config.h"
 #include "chrome/browser/extensions/api/dial/dial_api.h"
 #include "chrome/browser/extensions/api/dial/dial_api_factory.h"
 #include "chrome/browser/extensions/api/dial/dial_registry.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "extensions/common/switches.h"
 #include "extensions/test/extension_test_message_listener.h"
 #include "extensions/test/result_catcher.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "url/gurl.h"
 
 using extensions::Extension;
 using extensions::ResultCatcher;
-
-namespace dial = extensions::api::dial;
+using extensions::api::dial::DialDeviceData;
+using extensions::api::dial::DialDeviceDescriptionData;
+using extensions::api::dial::DialRegistry;
 
 namespace {
 
 class DialAPITest : public ExtensionApiTest {
  public:
   DialAPITest() {}
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     ExtensionApiTest::SetUpCommandLine(command_line);
     command_line->AppendSwitchASCII(
@@ skipping 13 matching lines @@
 // Test receiving DIAL API events.
 IN_PROC_BROWSER_TEST_F(DialAPITest, MAYBE_DeviceListEvents) {
   // Setup the test.
   ASSERT_TRUE(RunExtensionSubtest("dial/experimental", "device_list.html"));
 
   // Send three device list updates.
   scoped_refptr<extensions::DialAPI> api =
       extensions::DialAPIFactory::GetInstance()->GetForBrowserContext(
           profile());
   ASSERT_TRUE(api.get());
-  dial::DialRegistry::DeviceList devices;
+  DialRegistry::DeviceList devices;
 
   ResultCatcher catcher;
 
-  dial::DialDeviceData device1;
+  DialDeviceData device1;
   device1.set_device_id("1");
   device1.set_label("1");
   device1.set_device_description_url(GURL("http://127.0.0.1/dd.xml"));
 
   devices.push_back(device1);
   api->SendEventOnUIThread(devices);
 
-  dial::DialDeviceData device2;
+  DialDeviceData device2;
   device2.set_device_id("2");
   device2.set_label("2");
   device2.set_device_description_url(GURL("http://127.0.0.2/dd.xml"));
 
   devices.push_back(device2);
   api->SendEventOnUIThread(devices);
 
-  dial::DialDeviceData device3;
+  DialDeviceData device3;
   device3.set_device_id("3");
   device3.set_label("3");
   device3.set_device_description_url(GURL("http://127.0.0.3/dd.xml"));
 
   devices.push_back(device3);
   api->SendEventOnUIThread(devices);
 
   EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
@@ skipping 22 matching lines @@
 
   EXPECT_TRUE(listener.WaitUntilSatisfied());
 
   listener.Reply("go");
   EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
 IN_PROC_BROWSER_TEST_F(DialAPITest, OnError) {
   ASSERT_TRUE(RunExtensionSubtest("dial/experimental", "on_error.html"));
 }
+
+IN_PROC_BROWSER_TEST_F(DialAPITest, FetchDeviceDescription) {
+  scoped_refptr<extensions::DialAPI> api =
+      extensions::DialAPIFactory::GetInstance()->GetForBrowserContext(
+          profile());
+  ASSERT_TRUE(api.get());

[Wez, 2017/01/05 22:29:24]

nit: Omit .get() when testing a ptr as bool.

[mark a. foltz, 2017/01/09 21:38:08]

Done.

+
+  DialDeviceData test_device("testDeviceId",
+                             GURL("http://127.0.0.1/description.xml"),
+                             base::Time::Now());
+  test_device.set_label("testDevice");
+
+  DialDeviceDescriptionData test_description("<xml>testDescription</xml>",
+                                             GURL("http://127.0.0.1/apps"));
+  api->SetDeviceForTest(test_device, test_description);
+
+  ASSERT_TRUE(RunExtensionSubtest("dial/experimental",
+                                  "fetch_device_description.html"));

[Wez, 2017/01/05 22:29:24]

nit: Do we have any test cases for the API failing?

[mark a. foltz, 2017/01/09 21:38:08]

Added one.

+}