Issue 258383002: Revert 266822 "Remove dropped frame counting and task posting fr..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258383002: Revert 266822 "Remove dropped frame counting and task posting fr..." (Closed)

Created:
6 years, 7 months ago by alokp

Modified:
6 years, 7 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 266822 "Remove dropped frame counting and task posting fr..." Reason for revert: Speculative; may have made webgl conformance tests for video extensions flaky. > Remove dropped frame counting and task posting from VideoFrameCompositor. > > While developing VideoFrameScheduler it became apparent that we no longer need to post tasks to notify the compositor as scheduling is already being done on the compositor thread. If there are no posted tasks, it also means we don't need to track dropped frames due to missed scheduler notifications. > > BUG=110814 > > Review URL: https://codereview.chromium.org/251733005 TBR=scherkus@chromium.org BUG=368300 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266952

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+229 lines, -81 lines)			Patch
M	trunk/src/content/renderer/media/video_frame_compositor.h	View	2 chunks	+34 lines, -25 lines	0 comments	Download
M	trunk/src/content/renderer/media/video_frame_compositor.cc	View	2 chunks	+125 lines, -31 lines	0 comments	Download
M	trunk/src/content/renderer/media/video_frame_compositor_unittest.cc	View	6 chunks	+51 lines, -4 lines	0 comments	Download
M	trunk/src/content/renderer/media/webmediaplayer_impl.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/content/renderer/media/webmediaplayer_impl.cc	View	7 chunks	+18 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r266952.

Expand Messages | Collapse Messages