Factor out AutocompleteMatch creation from BookmarkProvider

components/bookmarks/browser/titled_url_match_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.

[sky, 2017/01/06 00:54:43]

2017

[mattreynolds, 2017/01/06 01:13:44]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/bookmarks/browser/titled_url_match.h"
+
+#include "base/macros.h"
+#include "base/strings/utf_string_conversions.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using bookmarks::TitledUrlMatch;
+using MatchPositions = bookmarks::TitledUrlMatch::MatchPositions;
+
+class TitledUrlMatchTest : public testing::Test {

[sky, 2017/01/06 00:54:43]

How come you need a class here? Can't you use the TEST macro, e.g.:

TEST(TitledUrlMatchTest, Empty...)

with no class for TitledUrlMatchTest?

[mattreynolds, 2017/01/06 01:13:44]

Cool, didn't know this was an option. I made the change in this file and
titled_url_match_utils_unittest.cc.

[Mark P, 2017/01/06 06:06:09]

Neat.  I didn't know it was an option either.

+ public:
+  TitledUrlMatchTest() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TitledUrlMatchTest);
+};
+
+TEST_F(TitledUrlMatchTest, EmptyOffsetsForEmptyMatchPositions) {
+  auto offsets = TitledUrlMatch::OffsetsFromMatchPositions(MatchPositions());
+  EXPECT_TRUE(offsets.empty());
+}
+
+TEST_F(TitledUrlMatchTest, OffsetsFromMatchPositions) {
+  MatchPositions match_positions = {{1, 3}, {4, 5}, {10, 15}};
+  std::vector<size_t> expected_offsets = {1, 3, 4, 5, 10, 15};
+  auto offsets = TitledUrlMatch::OffsetsFromMatchPositions(match_positions);
+  EXPECT_TRUE(
+      std::equal(offsets.begin(), offsets.end(), expected_offsets.begin()));
+}
+
+TEST_F(TitledUrlMatchTest, ReplaceOffsetsInEmptyMatchPositions) {
+  auto match_positions = TitledUrlMatch::ReplaceOffsetsInMatchPositions(
+      MatchPositions(), std::vector<size_t>());
+  EXPECT_TRUE(match_positions.empty());
+}
+
+TEST_F(TitledUrlMatchTest, ReplaceOffsetsInMatchPositions) {
+  MatchPositions orig_match_positions = {{1, 3}, {4, 5}, {10, 15}};
+  std::vector<size_t> offsets = {0, 2, 3, 4, 9, 14};
+  MatchPositions expected_match_positions = {{0, 2}, {3, 4}, {9, 14}};
+  auto match_positions = TitledUrlMatch::ReplaceOffsetsInMatchPositions(
+      orig_match_positions, offsets);
+  EXPECT_TRUE(std::equal(match_positions.begin(), match_positions.end(),
+                         expected_match_positions.begin()));
+}
+
+TEST_F(TitledUrlMatchTest, ReplaceOffsetsRemovesItemsWithNposOffsets) {
+  MatchPositions orig_match_positions = {{1, 3}, {4, 5}, {10, 15}, {17, 20}};
+  std::vector<size_t> offsets = {0,
+                                 base::string16::npos,
+                                 base::string16::npos,
+                                 4,
+                                 base::string16::npos,
+                                 base::string16::npos,
+                                 17,
+                                 20};
+  MatchPositions expected_match_positions = {{17, 20}};
+  auto match_positions = TitledUrlMatch::ReplaceOffsetsInMatchPositions(
+      orig_match_positions, offsets);
+  EXPECT_TRUE(std::equal(match_positions.begin(), match_positions.end(),
+                         expected_match_positions.begin()));
+}