content/renderer/browser_plugin/browser_plugin.cc - Issue 258373002: Towards moving guest management to chrome: Introduce GuestViewManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 258373002: Towards moving guest management to chrome: Introduce GuestViewManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with ToT Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/browser_plugin_guest_manager_delegate.h ('K') | « content/public/browser/content_browser_client.cc ('k') | content/renderer/browser_plugin/browser_plugin_manager.h » ('j') | content/renderer/browser_plugin/browser_plugin_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin.cc

diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc

index cf045843d620938894f1312518602b92c34f8c5a..c4ae752f41aaa801273c87aae122d4e2d766667d 100644

--- a/content/renderer/browser_plugin/browser_plugin.cc

+++ b/content/renderer/browser_plugin/browser_plugin.cc

@@ -289,7 +289,7 @@ bool BrowserPlugin::ParseSrcAttribute(std::string* error_message) {

// browser process in order to create a new guest.

if (before_first_navigation_) {

browser_plugin_manager()->AllocateInstanceID(

- weak_ptr_factory_.GetWeakPtr());

+ weak_ptr_factory_.GetWeakPtr(), src);

before_first_navigation_ = false;

}

return true;