Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.h

Issue 258373002: Towards moving guest management to chrome: Introduce GuestViewManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android build Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_plugin/browser_plugin_embedder.h
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.h b/content/browser/browser_plugin/browser_plugin_embedder.h
index e153a4df79af4261254b35a25c6d26489f907092..bce57a3094070b725604377d074e3584f2124bef 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.h
+++ b/content/browser/browser_plugin/browser_plugin_embedder.h
@@ -45,7 +45,7 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {
static BrowserPluginEmbedder* Create(WebContentsImpl* web_contents);
// Returns this embedder's WebContentsImpl.
- WebContentsImpl* GetWebContents();
+ WebContentsImpl* GetWebContents() const;
// Called when embedder's |rwh| has sent screen rects to renderer.
void DidSendScreenRects();
@@ -86,9 +86,9 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {
private:
friend class TestBrowserPluginEmbedder;
- BrowserPluginEmbedder(WebContentsImpl* web_contents);
+ explicit BrowserPluginEmbedder(WebContentsImpl* web_contents);
- BrowserPluginGuestManager* GetBrowserPluginGuestManager();
+ BrowserPluginGuestManager* GetBrowserPluginGuestManager() const;
bool DidSendScreenRectsCallback(BrowserPluginGuest* guest);
@@ -121,6 +121,8 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {
// status messages to the correct guest.
base::WeakPtr<BrowserPluginGuest> guest_started_drag_;
+ base::WeakPtrFactory<BrowserPluginEmbedder> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(BrowserPluginEmbedder);
};
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698