content/renderer/browser_plugin/browser_plugin_manager_impl.cc - Issue 258373002: Towards moving guest management to chrome: Introduce GuestViewManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager_impl.cc

Issue 258373002: Towards moving guest management to chrome: Introduce GuestViewManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guestview/guestview_manager.cc ('K') | « content/renderer/browser_plugin/browser_plugin_manager_impl.h ('k') | content/renderer/browser_plugin/mock_browser_plugin_manager.h » ('j') | content/test/test_content_browser_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin_manager_impl.cc

diff --git a/content/renderer/browser_plugin/browser_plugin_manager_impl.cc b/content/renderer/browser_plugin/browser_plugin_manager_impl.cc

index 4f0bed07fe6e1d306408bc2ab806a143f263047f..d4d6c87c5edb02a5f8e599a832b8124acd627ec3 100644

--- a/content/renderer/browser_plugin/browser_plugin_manager_impl.cc

+++ b/content/renderer/browser_plugin/browser_plugin_manager_impl.cc

@@ -30,12 +30,13 @@ BrowserPlugin* BrowserPluginManagerImpl::CreateBrowserPlugin(

}

void BrowserPluginManagerImpl::AllocateInstanceID(

- const base::WeakPtr<BrowserPlugin>& browser_plugin) {

+ const base::WeakPtr<BrowserPlugin>& browser_plugin,

+ const std::string& src) {

int request_id = ++request_id_counter_;

pending_allocate_guest_instance_id_requests_.insert(

std::make_pair(request_id, browser_plugin));

Send(new BrowserPluginHostMsg_AllocateInstanceID(

- browser_plugin->render_view_routing_id(), request_id));

+ browser_plugin->render_view_routing_id(), request_id, src));

}

bool BrowserPluginManagerImpl::Send(IPC::Message* msg) {