Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2318)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 258373002: Towards moving guest management to chrome: Introduce GuestViewManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 3d117b2c183eebbfc8856d5f9cf8b7e8d0f6a317..f66cff73c65df28f33741c64b4119aea9b09f16b 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -44,6 +44,7 @@
#include "chrome/browser/guestview/adview/adview_guest.h"
#include "chrome/browser/guestview/guestview.h"
#include "chrome/browser/guestview/guestview_constants.h"
+#include "chrome/browser/guestview/guestview_manager.h"
#include "chrome/browser/guestview/webview/webview_guest.h"
#include "chrome/browser/media/cast_transport_host_filter.h"
#include "chrome/browser/media/media_capture_devices_dispatcher.h"
@@ -815,6 +816,12 @@ content::WebContentsViewDelegate*
return chrome::CreateWebContentsViewDelegate(web_contents);
}
+content::BrowserPluginGuestManagerDelegate*
+ ChromeContentBrowserClient::GetGuestManagerDelegate(
lazyboy 2014/04/30 08:40:15 nit: think you don't need spaces here.
+ content::BrowserContext* context) {
+ return new GuestViewManager(context);
+}
+
void ChromeContentBrowserClient::GuestWebContentsCreated(
SiteInstance* guest_site_instance,
WebContents* guest_web_contents,
@@ -856,7 +863,8 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(
*guest_delegate =
GuestView::Create(guest_web_contents,
extension_id,
- guest->GetViewType());
+ guest->GetViewType(),
+ guest->AsWeakPtr());
return;
}
@@ -873,7 +881,8 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(
*guest_delegate =
GuestView::Create(guest_web_contents,
extension_id,
- GuestView::GetViewTypeFromString(api_type));
+ GuestView::GetViewTypeFromString(api_type),
+ base::WeakPtr<GuestView>());
}
void ChromeContentBrowserClient::GuestWebContentsAttached(

Powered by Google App Engine
This is Rietveld 408576698