Towards moving guest management to chrome: Introduce GuestViewManager

content/public/browser/browser_plugin_guest_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_BROWSER_PLUGIN_GUEST_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_BROWSER_PLUGIN_GUEST_DELEGATE_H_
 
 #include "base/callback_forward.h"
 #include "base/process/kill.h"
 #include "base/strings/string16.h"
 #include "base/values.h"
 #include "content/common/content_export.h"
 #include "content/public/common/browser_plugin_permission_type.h"
 #include "content/public/common/media_stream_request.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/size.h"
 #include "url/gurl.h"
 
 namespace content {
 
 class JavaScriptDialogManager;
 struct NativeWebKeyboardEvent;
+class WebContents;
 
 // Objects implement this interface to get notified about changes in the guest
 // WebContents and to provide necessary functionality.
 class CONTENT_EXPORT BrowserPluginGuestDelegate {
  public:
   virtual ~BrowserPluginGuestDelegate() {}
 
   // Add a message to the console.
   virtual void AddMessageToConsole(int32 level,
                                    const base::string16& message,
                                    int32 line_no,
                                    const base::string16& source_id) {}
 
   // Request the delegate to close this guest, and do whatever cleanup it needs
   // to do.
   virtual void Close() {}
 
   // Notification that the embedder has completed attachment.
   virtual void DidAttach() {}
 
+  // Returns the opener for this guest.
+  virtual WebContents* GetOpener() const;

[jam, 2014/05/02 19:09:06]

hmm, does this need to be in content? i haven't traced through all the usage of
this, but i'm wondering if chrome is the only place that needs to get/set this,
and it can stash it on the WC using a map or WCUD?

[Fady Samuel, 2014/05/02 21:28:20]

Currently, the New Window API still resides in the content layer. Once the New
Window API is moved to chrome, this will no longer be necessary. I added a TODO
above GetOpener and SetOpener.

+
   // Informs the delegate that the guest render process is gone. |status|
   // indicates whether the guest was killed, crashed, or was terminated
   // gracefully.
   virtual void GuestProcessGone(base::TerminationStatus status) {}
 
   // Informs the delegate that the embedder has been destroyed.
   virtual void EmbedderDestroyed() {}
 
   // Informs the delegate of a reply to the find request specified by
   // |request_id|.
@@ skipping 38 matching lines @@
   // |request_info|. A |callback| is provided to make the decision.
   virtual void RequestPermission(
       BrowserPluginPermissionType permission_type,
       const base::DictionaryValue& request_info,
       const PermissionResponseCallback& callback,
       bool allowed_by_default) {}
 
   // Requests resolution of a potentially relative URL.
   virtual GURL ResolveURL(const std::string& src);
 
+  // Informs the delegate of the WebContents that created delegate's associated
+  // WebContents.
+  virtual void SetOpener(WebContents* opener) {}
+
   // Notifies that the content size of the guest has changed in autosize mode.
   virtual void SizeChanged(const gfx::Size& old_size,
                            const gfx::Size& new_size) {}
 
   // Asks permission to use the camera and/or microphone. If permission is
   // granted, a call should be made to |callback| with the devices. If the
   // request is denied, a call should be made to |callback| with an empty list
   // of devices. |request| has the details of the request (e.g. which of audio
   // and/or video devices are requested, and lists of available devices).
   virtual void RequestMediaAccessPermission(
@@ skipping 14 matching lines @@
       const base::Callback<void(bool)>& callback) {}
 
   // Returns a pointer to a service to manage JavaScript dialogs. May return
   // NULL in which case dialogs aren't shown.
   virtual JavaScriptDialogManager* GetJavaScriptDialogManager();
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_BROWSER_PLUGIN_GUEST_DELEGATE_H_