Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py

Issue 2583723002: Use LocalWPT.test_patch when filtering exportable commits (Closed)
Patch Set: Add missing constant Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
index 16ef1b9831c0b6060c7d4976ec8be7e0a0ba7f43..1b7d914667e3791286b3b7c0a7239b757b839202 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
@@ -18,7 +18,6 @@ def mock_command_exec(vals):
return MockExecutive2(run_command_fn=run_fn)
-
class TestExporterTest(unittest.TestCase):
def setUp(self):
@@ -71,6 +70,14 @@ class TestExporterTest(unittest.TestCase):
return 'newer fake text'
elif 'facebeef' in args:
return 'older fake text'
+ elif git_command == 'remote':
+ return 'github'
+ elif git_command == 'format-patch':
+ return 'fake patch'
+ elif git_command == 'diff':
+ return 'fake patch diff'
+ elif git_command == 'diff-tree':
+ return 'fake\nfiles\nchanged'
else:
return ''
qyearsley 2016/12/22 22:04:54 This is definitely fine, although doing something

Powered by Google App Engine
This is Rietveld 408576698