Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber.h

Issue 2583703002: Record the tab state during data use (Closed)
Patch Set: Addressed comments' Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h b/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
index a05d8a8b57a2dec762ce3b0f4e5cadc14d83c61e..4f7927fea4db0bcf485748d2af5d03cd3603c475 100644
--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
@@ -55,8 +55,10 @@ class ChromeDataUseAscriber : public DataUseAscriber {
~ChromeDataUseAscriber() override;
// DataUseAscriber implementation:
- ChromeDataUseRecorder* GetDataUseRecorder(net::URLRequest* request,
- bool can_create_new) override;
+ ChromeDataUseRecorder* GetOrCreateDataUseRecorder(
+ net::URLRequest* request) override;
+ ChromeDataUseRecorder* GetDataUseRecorder(
+ const net::URLRequest* request) override;
void OnUrlRequestDestroyed(net::URLRequest* request) override;
std::unique_ptr<URLRequestClassifier> CreateURLRequestClassifier()
const override;
@@ -131,8 +133,8 @@ class ChromeDataUseAscriber : public DataUseAscriber {
DataUseRecorderEntry entry_;
};
- DataUseRecorderEntry GetDataUseRecorderEntry(net::URLRequest* request,
- bool can_create_new);
+ DataUseRecorderEntry GetOrCreateDataUseRecorderEntry(
+ net::URLRequest* request);
void OnDataUseCompleted(DataUseRecorderEntry entry);

Powered by Google App Engine
This is Rietveld 408576698