Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1892)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc

Issue 2583703002: Record the tab state during data use (Closed)
Patch Set: minor fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
index d6933aa77ef07aaff026fd555c69d4e8cb25e8ea..4221ac0750fb099daf4cb65b736155b25584b447 100644
--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
@@ -115,13 +115,11 @@ TEST_F(ChromeDataUseAscriberTest, RenderFrameShownAndHidden) {
kRenderProcessId, kRenderFrameId, true, (void*)request.get());
ascriber()->WasShownOrHidden(kRenderProcessId, kRenderFrameId, true);
- EXPECT_TRUE(
- ascriber()->GetDataUseRecorder(request.get(), true)->is_visible());
+ EXPECT_TRUE(ascriber()->GetDataUseRecorder(*request)->is_visible());
// Hide the frame, and the visibility should be updated.
ascriber()->WasShownOrHidden(kRenderProcessId, kRenderFrameId, false);
- EXPECT_FALSE(
- ascriber()->GetDataUseRecorder(request.get(), true)->is_visible());
+ EXPECT_FALSE(ascriber()->GetDataUseRecorder(*request)->is_visible());
ascriber()->RenderFrameDeleted(kRenderProcessId, kRenderFrameId, -1, -1);
}
@@ -140,13 +138,11 @@ TEST_F(ChromeDataUseAscriberTest, RenderFrameHiddenAndShown) {
kRenderProcessId, kRenderFrameId, true, (void*)request.get());
ascriber()->WasShownOrHidden(kRenderProcessId, kRenderFrameId, false);
- EXPECT_FALSE(
- ascriber()->GetDataUseRecorder(request.get(), true)->is_visible());
+ EXPECT_FALSE(ascriber()->GetDataUseRecorder(*request)->is_visible());
// Show the frame, and the visibility should be updated.
ascriber()->WasShownOrHidden(kRenderProcessId, kRenderFrameId, true);
- EXPECT_TRUE(
- ascriber()->GetDataUseRecorder(request.get(), true)->is_visible());
+ EXPECT_TRUE(ascriber()->GetDataUseRecorder(*request)->is_visible());
ascriber()->RenderFrameDeleted(kRenderProcessId, kRenderFrameId, -1, -1);
}
@@ -164,8 +160,7 @@ TEST_F(ChromeDataUseAscriberTest, RenderFrameHostChanged) {
GURL("http://test.com"), content::GlobalRequestID(kRenderProcessId, 0),
kRenderProcessId, kRenderFrameId, true, (void*)request.get());
ascriber()->WasShownOrHidden(kRenderProcessId, kRenderFrameId, true);
- EXPECT_TRUE(
- ascriber()->GetDataUseRecorder(request.get(), true)->is_visible());
+ EXPECT_TRUE(ascriber()->GetDataUseRecorder(*request)->is_visible());
// Create a new render frame and swap it.
ascriber()->RenderFrameCreated(kRenderProcessId + 1, kRenderFrameId + 1, -1,

Powered by Google App Engine
This is Rietveld 408576698