Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: ios/web/shell/test/page_state_egtest.mm

Issue 2583683004: Disable EarlGrey web shell tests that fail on device. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/shell/test/navigation_egtest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/shell/test/page_state_egtest.mm
diff --git a/ios/web/shell/test/page_state_egtest.mm b/ios/web/shell/test/page_state_egtest.mm
index 56916b0844af7e799e5feb5040a5733892cfd742..4cb32590adb2282298fb83acbaa223b12495a40d 100644
--- a/ios/web/shell/test/page_state_egtest.mm
+++ b/ios/web/shell/test/page_state_egtest.mm
@@ -57,9 +57,15 @@ using web::test::HttpServer;
@implementation PageStateTestCase
+// TODO(crbug.com/675015): Re-enable this test on device.
+#if TARGET_IPHONE_SIMULATOR
+#define MAYBE_testScrollPositionRestoring testScrollPositionRestoring
+#else
+#define MAYBE_testScrollPositionRestoring FLAKY_testScrollPositionRestoring
+#endif
// Tests that page scroll position of a page is restored upon returning to the
// page via the back/forward buttons.
-- (void)testScrollPositionRestoring {
+- (void)MAYBE_testScrollPositionRestoring {
// TODO(crbug.com/670700): Re-enable this test.
if (!base::ios::IsRunningOnIOS10OrLater()) {
EARL_GREY_TEST_DISABLED(@"Test disabled on pre-iOS 10");
« no previous file with comments | « ios/web/shell/test/navigation_egtest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698