Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: ios/web/shell/test/context_menu_egtest.mm

Issue 2583683004: Disable EarlGrey web shell tests that fail on device. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/shell/test/navigation_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/shell/test/context_menu_egtest.mm
diff --git a/ios/web/shell/test/context_menu_egtest.mm b/ios/web/shell/test/context_menu_egtest.mm
index b32ba62c20f39b9f1ba66902f6c630217682bbf4..d87f608ffa035ac92a7d0e6e2f853c768fe199f4 100644
--- a/ios/web/shell/test/context_menu_egtest.mm
+++ b/ios/web/shell/test/context_menu_egtest.mm
@@ -33,8 +33,14 @@ using testing::elementToDismissContextMenu;
@implementation ContextMenuTestCase
+// TODO(crbug.com/675015): Re-enable this test on device.
+#if TARGET_IPHONE_SIMULATOR
+#define MAYBE_testContextMenu testContextMenu
+#else
+#define MAYBE_testContextMenu FLAKY_testContextMenu
+#endif
// Tests context menu appears on a regular link.
-- (void)testContextMenu {
+- (void)MAYBE_testContextMenu {
// Create map of canned responses and set up the test HTML server.
std::map<GURL, std::string> responses;
GURL initialURL = web::test::HttpServer::MakeUrl("http://contextMenuOpen");
@@ -69,8 +75,16 @@ using testing::elementToDismissContextMenu;
[[EarlGrey selectElementWithMatcher:copyItem] assertWithMatcher:grey_nil()];
}
+// TODO(crbug.com/675015): Re-enable this test on device.
+#if TARGET_IPHONE_SIMULATOR
+#define MAYBE_testContextMenuWebkitTouchCalloutNone \
+ testContextMenuWebkitTouchCalloutNone
+#else
+#define MAYBE_testContextMenuWebkitTouchCalloutNone \
+ FLAKY_testContextMenuWebkitTouchCalloutNone
+#endif
// Tests context menu on element that has WebkitTouchCallout set to none.
-- (void)testContextMenuWebkitTouchCalloutNone {
+- (void)MAYBE_testContextMenuWebkitTouchCalloutNone {
// Create map of canned responses and set up the test HTML server.
std::map<GURL, std::string> responses;
GURL initialURL =
@@ -98,9 +112,17 @@ using testing::elementToDismissContextMenu;
[[EarlGrey selectElementWithMatcher:copyItem] assertWithMatcher:grey_nil()];
}
+// TODO(crbug.com/675015): Re-enable this test on device.
+#if TARGET_IPHONE_SIMULATOR
+#define MAYBE_testContextMenuWebkitTouchCalloutNoneFromAncestor \
+ testContextMenuWebkitTouchCalloutNoneFromAncestor
+#else
+#define MAYBE_testContextMenuWebkitTouchCalloutNoneFromAncestor \
+ FLAKY_testContextMenuWebkitTouchCalloutNoneFromAncestor
+#endif
// Tests context menu on element that has WebkitTouchCallout set to none from an
// ancestor.
-- (void)testContextMenuWebkitTouchCalloutNoneFromAncestor {
+- (void)MAYBE_testContextMenuWebkitTouchCalloutNoneFromAncestor {
// Create map of canned responses and set up the test HTML server.
std::map<GURL, std::string> responses;
GURL initialURL =
@@ -129,9 +151,17 @@ using testing::elementToDismissContextMenu;
[[EarlGrey selectElementWithMatcher:copyItem] assertWithMatcher:grey_nil()];
}
+// TODO(crbug.com/675015): Re-enable this test on device.
+#if TARGET_IPHONE_SIMULATOR
+#define MAYBE_testContextMenuWebkitTouchCalloutOverride \
+ testContextMenuWebkitTouchCalloutOverride
+#else
+#define MAYBE_testContextMenuWebkitTouchCalloutOverride \
+ FLAKY_testContextMenuWebkitTouchCalloutOverride
+#endif
// Tests context menu on element that has WebkitTouchCallout set to none from an
// ancestor and overridden.
-- (void)testContextMenuWebkitTouchCalloutOverride {
+- (void)MAYBE_testContextMenuWebkitTouchCalloutOverride {
// Create map of canned responses and set up the test HTML server.
std::map<GURL, std::string> responses;
GURL initialURL =
« no previous file with comments | « no previous file | ios/web/shell/test/navigation_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698