Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2583673002: When creating a JIT app snapshot, don't recreate the VM isolate snapshot. (Closed)

Created:
4 years ago by rmacnak
Modified:
4 years ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, hausner
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When creating a JIT app snapshot, don't recreate the VM isolate snapshot. Prerequisite for using multiple isolate snapshots in the same process. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/1a41627eccfea79cb440924e25a6601e003e56d7

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -75 lines) Patch
M runtime/bin/main.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 6 chunks +27 lines, -5 lines 0 comments Download
M runtime/vm/dart.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 3 chunks +3 lines, -13 lines 0 comments Download
M runtime/vm/pages.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/stub_code.h View 5 chunks +15 lines, -10 lines 0 comments Download
M runtime/vm/stub_code.cc View 3 chunks +9 lines, -30 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years ago (2016-12-15 22:30:40 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/2583673002/diff/1/runtime/vm/stub_code.cc File runtime/vm/stub_code.cc (right): https://codereview.chromium.org/2583673002/diff/1/runtime/vm/stub_code.cc#newcode23 runtime/vm/stub_code.cc:23: StubEntry* StubCode::entries_[kNumStubEntries] = { StubEntry* const?
4 years ago (2016-12-16 22:43:50 UTC) #3
rmacnak
https://codereview.chromium.org/2583673002/diff/1/runtime/vm/stub_code.cc File runtime/vm/stub_code.cc (right): https://codereview.chromium.org/2583673002/diff/1/runtime/vm/stub_code.cc#newcode23 runtime/vm/stub_code.cc:23: StubEntry* StubCode::entries_[kNumStubEntries] = { On 2016/12/16 22:43:50, Florian Schneider ...
4 years ago (2016-12-16 23:42:40 UTC) #4
rmacnak
4 years ago (2016-12-16 23:44:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a41627eccfea79cb440924e25a6601e003e56d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698