Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/clang/scripts/run_tool.py

Issue 2583623002: Fix filtering of where edits are applied when --all switch is used. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/run_tool.py
diff --git a/tools/clang/scripts/run_tool.py b/tools/clang/scripts/run_tool.py
index 205d281556c6b396157d7e2cb799e6ca6cb320fd..42b085eb1a6f63e84ce778c7d3f80b1d09c273ea 100755
--- a/tools/clang/scripts/run_tool.py
+++ b/tools/clang/scripts/run_tool.py
@@ -319,11 +319,10 @@ def main():
if args.generate_compdb:
compile_db.GenerateWithNinja(args.compile_database)
+ filenames = set(_GetFilesFromGit(args.path_filter))
if args.all:
- filenames = set(_GetFilesFromCompileDB(args.compile_database))
- source_filenames = filenames
+ source_filenames = set(_GetFilesFromCompileDB(args.compile_database))
else:
- filenames = set(_GetFilesFromGit(args.path_filter))
# Filter out files that aren't C/C++/Obj-C/Obj-C++.
extensions = frozenset(('.c', '.cc', '.cpp', '.m', '.mm'))
source_filenames = [f
@@ -343,4 +342,4 @@ def main():
if __name__ == '__main__':
- sys.exit(main())
+ sys.exit(main())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698