Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: third_party/closure_compiler/externs/compiled_resources2.gyp

Issue 2583573002: [Closure Externs] Generate closure compiler externs as part of compile
Patch Set: missing Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_compiler/externs/compiled_resources2.gyp
diff --git a/third_party/closure_compiler/externs/compiled_resources2.gyp b/third_party/closure_compiler/externs/compiled_resources2.gyp
index 488f6deb5029daaadb6789d6a3d76026e48fb578..933769d88af1882e3170d8338cf228d13c724429 100644
--- a/third_party/closure_compiler/externs/compiled_resources2.gyp
+++ b/third_party/closure_compiler/externs/compiled_resources2.gyp
@@ -45,7 +45,7 @@
'includes': ['../include_js.gypi'],
},
{
- 'target_name': 'developer_private',
+ 'target_name': '../../../out/gnd/gen/third_party/closure_compiler/externs/developer_private',
Devlin 2016/12/15 18:56:40 This is obviously wrong. :) How should this be?
Dan Beam 2016/12/16 05:39:52 it's hard to say exactly how GYP and GN should sha
Dirk Pranke 2017/01/09 05:20:02 We shouldn't generate things into src/. I'm not su
'includes': ['../include_js.gypi'],
},
{

Powered by Google App Engine
This is Rietveld 408576698