Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2583483002: [cc] Adds source_id and sequence_number to BeginFrameArgs. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index cc1d26880258674da88c599cf8d750fa1455077d..6a826eb2ad50fa9c2ad42096ff1bbe426b9a3c28 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -1518,8 +1518,9 @@ void RenderWidgetHostViewAndroid::StopObservingRootWindow() {
}
void RenderWidgetHostViewAndroid::SendBeginFrame(cc::BeginFrameArgs args) {
- TRACE_EVENT1("cc", "RenderWidgetHostViewAndroid::SendBeginFrame",
- "frame_time_us", args.frame_time.ToInternalValue());
+ TRACE_EVENT2("cc", "RenderWidgetHostViewAndroid::SendBeginFrame",
+ "frame_number", args.sequence_number, "frame_time_us",
+ args.frame_time.ToInternalValue());
// Synchronous compositor does not use deadline-based scheduling.
// TODO(brianderson): Replace this hardcoded deadline after Android
@@ -1925,7 +1926,7 @@ void RenderWidgetHostViewAndroid::OnBeginFrame(const cc::BeginFrameArgs& args) {
if (sync_compositor_ && args.type == cc::BeginFrameArgs::MISSED)
return;
- // Update |last_begin_frame_args_| before handling
+ // crbug.com/675289: Update |last_begin_frame_args_| before handling
nasko 2016/12/21 17:31:45 nit: https:// so code search can linkify it.
Eric Seckler 2016/12/22 09:20:27 Uh, this must have snuck back during rebase. Shoul
// |outstanding_begin_frame_requests_| to prevent the BeginFrameSource from
// sending the same MISSED args in infinite recursion. This may otherwise
// happen if |host_->FlushInput()| causes a synchronous OnSetNeedsFlushInput()

Powered by Google App Engine
This is Rietveld 408576698