Fix google_toolbox_for_mac.gyp to not have duplicate files.

Fix build/mac/edit_xibs.sh.

This removes duplicate files from google_toolbox_for_mac.gyp and fixes up the
script to include common.gypi implicitly.

R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267199

[Mark Mentovai, 2014-04-29 20:42:04]

The deduplication is fine, though.

https://codereview.chromium.org/258343002/diff/1/third_party/google_toolbox_f...
File third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp (right):

https://codereview.chromium.org/258343002/diff/1/third_party/google_toolbox_f...
third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:9: 'type':
'static_library',
I don’t think that you should make this change, because it will result in a new
copy of GTM being statically linked into a number of modules in a
component=shared_library build, which will cause the Objective-C runtime to say

"Class %s is implemented in both %s and %s. One of the two will be used. Which
one is undefined."

[Robert Sesek, 2014-04-29 20:56:48]

PTAL, rejiggered the CL and description.

[Mark Mentovai, 2014-04-29 21:02:35]

LGTM

[Robert Sesek, 2014-04-29 21:03:21]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-04-29 21:04:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/258343002/20001

[commit-bot: I haz the power, 2014-04-29 22:07:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 22:07:03]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium

[Robert Sesek, 2014-04-29 22:07:55]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-04-29 22:13:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/258343002/20001

[commit-bot: I haz the power, 2014-04-29 22:19:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 22:19:07]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium

[Robert Sesek, 2014-04-29 22:19:54]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-04-29 22:21:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/258343002/20001

[commit-bot: I haz the power, 2014-04-29 23:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 23:20:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium

[Robert Sesek, 2014-04-30 00:21:07]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2014-04-30 00:21:15]

The CQ bit was unchecked by rsesek@chromium.org

[Robert Sesek, 2014-04-30 14:36:06]

Committed patchset #2 manually as r267199.