Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: ash/common/system/chromeos/network/sms_observer_unittest.cc

Issue 2583393002: Send notification to users upon receiving sms messages (Closed)
Patch Set: update return type Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/system/chromeos/network/sms_observer.cc ('k') | ash/common/system/chromeos/network/tray_sms.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/chromeos/network/sms_observer_unittest.cc
diff --git a/ash/common/system/chromeos/network/sms_observer_unittest.cc b/ash/common/system/chromeos/network/sms_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5665b8f4f53ee47ed5096e3e9e65d40fef3114df
--- /dev/null
+++ b/ash/common/system/chromeos/network/sms_observer_unittest.cc
@@ -0,0 +1,146 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/common/system/chromeos/network/sms_observer.h"
+#include "ash/common/shelf/shelf_widget.h"
+#include "ash/common/shelf/wm_shelf.h"
+#include "ash/public/interfaces/vpn_list.mojom.h"
+#include "ash/test/ash_test_base.h"
+#include "base/macros.h"
+#include "base/strings/utf_string_conversions.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/message_center/message_center.h"
+#include "ui/message_center/notification.h"
+#include "ui/message_center/notification_list.h"
+
+namespace ash {
+namespace test {
+
+class SmsObserverTest : public AshTestBase {
+ public:
+ SmsObserverTest() {}
+ ~SmsObserverTest() override {}
+
+ SmsObserver* GetSmsObserver(ShelfWidget* shelf_widget) {
+ return shelf_widget->sms_observer_.get();
+ }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(SmsObserverTest);
+};
+
+std::unique_ptr<base::DictionaryValue> CreateMessage(
+ const char* kDefaultNumber,
+ const char* kDefaultMessage,
+ const char* kDefaultTimestamp) {
+ std::unique_ptr<base::DictionaryValue> sms(new base::DictionaryValue());
+ if (kDefaultNumber)
+ sms->SetString("number", kDefaultNumber);
+ if (kDefaultMessage)
+ sms->SetString("text", kDefaultMessage);
+ if (kDefaultTimestamp)
+ sms->SetString("timestamp", kDefaultMessage);
+ return sms;
+}
+
+// Verify if notification is received after receiving a sms message with
+// number and content.
+TEST_F(SmsObserverTest, SendTextMessage) {
+ SmsObserver* sms_observer = GetSmsObserver(GetPrimaryShelf()->shelf_widget());
+ EXPECT_EQ(
+ 0u,
+ message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+
+ sms_observer->MessageReceived(*CreateMessage("000-000-0000",
+ "FakeSMSClient: Test Message.",
+ "Fri Jun 8 13:26:04 EDT 2016"));
+
+ const message_center::NotificationList::Notifications notifications =
+ message_center::MessageCenter::Get()->GetVisibleNotifications();
+ EXPECT_EQ(1u, notifications.size());
+
+ EXPECT_EQ((*notifications.begin())->title(),
+ base::ASCIIToUTF16("000-000-0000"));
+ EXPECT_EQ((*notifications.begin())->message(),
+ base::ASCIIToUTF16("FakeSMSClient: Test Message."));
+ message_center::MessageCenter::Get()->RemoveAllNotifications(
+ false /* by_user */, message_center::MessageCenter::RemoveType::ALL);
+ EXPECT_EQ(
+ 0u,
+ message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if no notification is received if phone number is missing in sms
+// message.
+TEST_F(SmsObserverTest, TextMessageMissingNumber) {
+ SmsObserver* sms_observer = GetSmsObserver(GetPrimaryShelf()->shelf_widget());
+ EXPECT_EQ(
+ 0u,
+ message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+ sms_observer->MessageReceived(*CreateMessage(
+ nullptr, "FakeSMSClient: Test Message.", "Fri Jun 8 13:26:04 EDT 2016"));
+ EXPECT_EQ(
+ 0u,
+ message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if no notification is received if text body is empty in sms message.
+TEST_F(SmsObserverTest, TextMessageEmptyText) {
+ SmsObserver* sms_observer = GetSmsObserver(GetPrimaryShelf()->shelf_widget());
+ EXPECT_EQ(
+ 0u,
+ message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+ sms_observer->MessageReceived(
+ *CreateMessage("000-000-0000", "", "Fri Jun 8 13:26:04 EDT 2016"));
+ EXPECT_EQ(
+ 0u,
+ message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if no notification is received if the text is missing in sms message.
+TEST_F(SmsObserverTest, TextMessageMissingText) {
+ SmsObserver* sms_observer = GetSmsObserver(GetPrimaryShelf()->shelf_widget());
+ EXPECT_EQ(
+ 0u,
+ message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+ sms_observer->MessageReceived(
+ *CreateMessage("000-000-0000", nullptr, "Fri Jun 8 13:26:04 EDT 2016"));
+ EXPECT_EQ(
+ 0u,
+ message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if 2 notification received after receiving 2 sms messages from the
+// same number.
+TEST_F(SmsObserverTest, MultipleTextMessages) {
+ SmsObserver* sms_observer = GetSmsObserver(GetPrimaryShelf()->shelf_widget());
+ EXPECT_EQ(
+ 0u,
+ message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+
+ sms_observer->MessageReceived(*CreateMessage("000-000-0000", "first message",
+ "Fri Jun 8 13:26:04 EDT 2016"));
+
+ sms_observer->MessageReceived(*CreateMessage("000-000-0000", "second message",
+ "Fri Jun 8 13:26:04 EDT 2016"));
+ const message_center::NotificationList::Notifications notifications =
+ message_center::MessageCenter::Get()->GetVisibleNotifications();
+ EXPECT_EQ(2u, notifications.size());
+
+ for (message_center::Notification* iter : notifications) {
+ if (iter->id().find("chrome://network/sms1") != std::string::npos) {
+ EXPECT_EQ(iter->title(), base::ASCIIToUTF16("000-000-0000"));
+ EXPECT_EQ(iter->message(), base::ASCIIToUTF16("first message"));
+ } else if (iter->id().find("chrome://network/sms2") != std::string::npos) {
+ EXPECT_EQ(iter->title(), base::ASCIIToUTF16("000-000-0000"));
+ EXPECT_EQ(iter->message(), base::ASCIIToUTF16("second message"));
+ } else {
+ ASSERT_TRUE(false);
+ }
+ }
+}
+
+} // namespace test
+} // namespace ash
« no previous file with comments | « ash/common/system/chromeos/network/sms_observer.cc ('k') | ash/common/system/chromeos/network/tray_sms.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698