Send notification to users upon receiving sms messages

ash/common/system/chromeos/network/sms_observer_unittest.cc

Index: ash/common/system/chromeos/network/sms_observer_unittest.cc
diff --git a/ash/common/system/chromeos/network/sms_observer_unittest.cc b/ash/common/system/chromeos/network/sms_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1d7c917577e31abe2c4ca1329966167827689f96
--- /dev/null
+++ b/ash/common/system/chromeos/network/sms_observer_unittest.cc
@@ -0,0 +1,153 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/common/system/chromeos/network/sms_observer.h"
+#include "ash/common/shelf/shelf_widget.h"
+#include "ash/common/shelf/wm_shelf.h"
+#include "ash/public/interfaces/vpn_list.mojom.h"
+#include "ash/test/ash_test_base.h"
+#include "base/macros.h"
+#include "base/strings/utf_string_conversions.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/message_center/message_center.h"
+#include "ui/message_center/notification.h"
+#include "ui/message_center/notification_list.h"
+
+namespace ash {
+namespace test {
+
+class SmsObserverTest : public AshTestBase {
+ public:
+  SmsObserverTest() {}
+  ~SmsObserverTest() override {}
+
+  SmsObserver* GetSmsObserver(ShelfWidget* shelf_widget) {
+    return shelf_widget->sms_observer_.get();
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SmsObserverTest);
+};
+
+// Verify if notification is received after receiving a sms message with
+// number and content.
+TEST_F(SmsObserverTest, SendTextMessage) {
+  SmsObserver* sms_observer = GetSmsObserver(GetPrimaryShelf()->shelf_widget());
+  EXPECT_EQ(
+      0u,
+      message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+  base::DictionaryValue* sms = new base::DictionaryValue();
+  sms->SetString("number", "000-000-0000");
+  sms->SetString("text", "FakeSMSClient: Test Message.");
+  sms->SetString("timestamp", "Fri Jun  8 13:26:04 EDT 2016");

[stevenjb, 2017/02/07 22:30:25]

You set up a test message in several places, it would be easier to read with a
helper function (also, sms leaks) e.g.:

base::unique_ptr<DictionaryValue> sms = CreateMessage(kDefaultNumber,
kDefaultMessage, kDefaultTimestamp);

[yiyix, 2017/02/09 02:01:48]

You are right, a helper function would save many line. 

+  EXPECT_EQ(
+      0u,
+      message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+
+  sms_observer->MessageReceived(*sms);
+
+  const message_center::NotificationList::Notifications notifications =
+      message_center::MessageCenter::Get()->GetVisibleNotifications();
+  EXPECT_EQ(1u, notifications.size());
+
+  EXPECT_EQ((*notifications.begin())->title(),
+            base::ASCIIToUTF16("000-000-0000"));
+  EXPECT_EQ((*notifications.begin())->message(),
+            base::ASCIIToUTF16("FakeSMSClient: Test Message."));
+  message_center::MessageCenter::Get()->RemoveAllNotifications(
+      false /* by_user */, message_center::MessageCenter::RemoveType::ALL);
+  EXPECT_EQ(
+      0u,
+      message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if no notification is received if phone number is missing in sms
+// message.
+TEST_F(SmsObserverTest, TextMessageMissingNumber) {
+  SmsObserver* sms_observer = GetSmsObserver(GetPrimaryShelf()->shelf_widget());
+  EXPECT_EQ(
+      0u,
+      message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+  base::DictionaryValue* sms = new base::DictionaryValue();
+  sms->SetString("text", "FakeSMSClient: Test Message.");
+  sms->SetString("timestamp", "Fri Jun  8 13:26:04 EDT 2016");
+
+  sms_observer->MessageReceived(*sms);
+  EXPECT_EQ(
+      0u,
+      message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if no notification is received if text body is empty in sms message.
+TEST_F(SmsObserverTest, TextMessageEmptyText) {
+  SmsObserver* sms_observer = GetSmsObserver(GetPrimaryShelf()->shelf_widget());
+  EXPECT_EQ(
+      0u,
+      message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+  base::DictionaryValue* sms = new base::DictionaryValue();
+  sms->SetString("number", "000-000-0000");
+  sms->SetString("text", "");
+  sms->SetString("timestamp", "Fri Jun  8 13:26:04 EDT 2016");
+
+  sms_observer->MessageReceived(*sms);
+  EXPECT_EQ(
+      0u,
+      message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if no notification is received if the text is missing in sms message.
+TEST_F(SmsObserverTest, TextMessageMissingText) {
+  SmsObserver* sms_observer = GetSmsObserver(GetPrimaryShelf()->shelf_widget());
+  EXPECT_EQ(
+      0u,
+      message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+  base::DictionaryValue* sms = new base::DictionaryValue();
+  sms->SetString("number", "000-000-0000");
+  sms->SetString("timestamp", "Fri Jun  8 13:26:04 EDT 2016");
+
+  sms_observer->MessageReceived(*sms);
+  EXPECT_EQ(
+      0u,
+      message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+}
+
+// Verify if 2 notification received after receiving 2 sms messages from the
+// same number.
+TEST_F(SmsObserverTest, MultipleTextMessages) {
+  SmsObserver* sms_observer = GetSmsObserver(GetPrimaryShelf()->shelf_widget());
+  EXPECT_EQ(
+      0u,
+      message_center::MessageCenter::Get()->GetVisibleNotifications().size());
+  base::DictionaryValue* sms = new base::DictionaryValue();
+  sms->SetString("number", "000-000-0000");
+  sms->SetString("text", "first message");
+  sms->SetString("timestamp", "Fri Jun  8 13:26:04 EDT 2016");
+
+  sms_observer->MessageReceived(*sms);
+
+  base::DictionaryValue* sms2 = new base::DictionaryValue();
+  sms2->SetString("number", "000-000-0000");
+  sms2->SetString("text", "second message");
+  sms2->SetString("timestamp", "Fri Jun  8 13:26:04 EDT 2016");
+  sms_observer->MessageReceived(*sms2);
+  const message_center::NotificationList::Notifications notifications =
+      message_center::MessageCenter::Get()->GetVisibleNotifications();
+  EXPECT_EQ(2u, notifications.size());
+
+  for (message_center::Notification* iter : notifications) {
+    if (iter->id().find("chrome://network/sms1") != std::string::npos) {
+      EXPECT_EQ(iter->title(), base::ASCIIToUTF16("000-000-0000"));
+      EXPECT_EQ(iter->message(), base::ASCIIToUTF16("first message"));
+    } else if (iter->id().find("chrome://network/sms2") != std::string::npos) {
+      EXPECT_EQ(iter->title(), base::ASCIIToUTF16("000-000-0000"));
+      EXPECT_EQ(iter->message(), base::ASCIIToUTF16("second message"));
+    } else {
+      NOTREACHED();

[stevenjb, 2017/02/07 22:30:25]

Use ASSERT_TRUE(false) instead of NOTREACHED in tests. (NOTREACHED crashes in
debug test runs only, making the failure difficult to identify).

[yiyix, 2017/02/09 02:01:48]

Good to know. Updated.

+    }
+  }
+}
+
+}  // namespace test
+}  // namespace ash