Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: ash/common/system/status_area_widget.cc

Issue 2583393002: Send notification to users upon receiving sms messages (Closed)
Patch Set: address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/status_area_widget.cc
diff --git a/ash/common/system/status_area_widget.cc b/ash/common/system/status_area_widget.cc
index 1fe17f64284d53add21b975cd45565e34177b97b..be2cbeb7339b5c7cd4b1d934cb97ad85bb69141a 100644
--- a/ash/common/system/status_area_widget.cc
+++ b/ash/common/system/status_area_widget.cc
@@ -146,13 +146,11 @@ bool StatusAreaWidget::ShouldShowShelf() const {
if (!wm_shelf_->IsVisible())
return false;
sadrul 2017/02/07 05:42:20 You can remove this too.
yiyix 2017/02/07 22:03:22 true, I don't need a separate case for this to ret
- // If the shelf is currently visible, don't hide the shelf if the mouse
- // is in any of the notification bubbles.
- return system_tray_ && system_tray_->IsMouseInNotificationBubble();
+ return false;
}
bool StatusAreaWidget::IsMessageBubbleShown() const {
- return ((system_tray_ && system_tray_->IsAnyBubbleVisible()) ||
+ return ((system_tray_ && system_tray_->IsSystemBubbleVisible()) ||
(web_notification_tray_ &&
web_notification_tray_->IsMessageCenterBubbleVisible()));
}

Powered by Google App Engine
This is Rietveld 408576698