Send notification to users upon receiving sms messages

ash/common/system/chromeos/network/sms_observer.cc

Index: ash/common/system/chromeos/network/sms_observer.cc
diff --git a/ash/common/system/chromeos/network/sms_observer.cc b/ash/common/system/chromeos/network/sms_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..39875ca9b5204d932083cec72ba97ba10b9e2405
--- /dev/null
+++ b/ash/common/system/chromeos/network/sms_observer.cc
@@ -0,0 +1,93 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <utility>
+
+#include "ash/common/material_design/material_design_controller.h"
+#include "ash/common/metrics/user_metrics_action.h"
+#include "ash/common/system/chromeos/network/sms_observer.h"
+#include "ash/common/system/system_notifier.h"
+#include "ash/common/system/tray/tray_constants.h"
+#include "ash/common/wm_shell.h"
+#include "ash/resources/vector_icons/vector_icons.h"
+#include "base/memory/ptr_util.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chromeos/network/network_event_log.h"
+#include "chromeos/network/network_handler.h"
+#include "grit/ash_resources.h"
+#include "grit/ash_strings.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/gfx/paint_vector_icon.h"
+#include "ui/message_center/message_center.h"
+#include "ui/views/view.h"
+
+namespace ash {
+
+const char SmsObserver::kNotificationId[] = "chrome://network/sms";
+
+SmsObserver::SmsObserver() : message_id_(0) {
+  // TODO(armansito): SMS could be a special case for cellular that requires a
+  // user (perhaps the owner) to be logged in. If that is the case, then an
+  // additional check should be done before subscribing for SMS notifications.
+  if (chromeos::NetworkHandler::IsInitialized())
+    chromeos::NetworkHandler::Get()->network_sms_handler()->AddObserver(this);
+}
+
+SmsObserver::~SmsObserver() {
+  if (chromeos::NetworkHandler::IsInitialized()) {
+    chromeos::NetworkHandler::Get()->network_sms_handler()->RemoveObserver(
+        this);
+  }
+}
+
+void SmsObserver::MessageReceived(const base::DictionaryValue& message) {
+  std::string message_text;
+  if (!message.GetStringWithoutPathExpansion(
+          chromeos::NetworkSmsHandler::kTextKey, &message_text)) {
+    NET_LOG_ERROR("SMS message contains no content.", "");
+    return;
+  }
+  // TODO(armansito): A message might be due to a special "Message Waiting"
+  // state that the message is in. Once SMS handling moves to shill, such
+  // messages should be filtered there so that this check becomes unnecessary.
+  if (message_text.empty()) {
+    NET_LOG_DEBUG("SMS has empty content text. Ignoring.", "");
+    return;
+  }
+  std::string message_number;
+  if (!message.GetStringWithoutPathExpansion(
+          chromeos::NetworkSmsHandler::kNumberKey, &message_number)) {
+    NET_LOG_DEBUG("SMS contains no number. Ignoring.", "");
+    return;
+  }
+
+  NET_LOG_DEBUG(
+      "Received SMS from: " + message_number + " with text: " + message_text,
+      "");
+  message_id_++;
+  Update(&message, message_text, message_number);
+}
+
+void SmsObserver::Update(const base::DictionaryValue* message,
+                         std::string message_text,
+                         std::string message_number) {
+  gfx::Image image(gfx::Image(

[tdanderson, 2017/02/07 00:15:45]

You don't need the inner gfx::Image here, just gfx::Image
image(CreateVectorIcon()) is sufficient.

Furthermore I think you want |image| to be type ImageSkia instead of Image.

[yiyix, 2017/02/07 22:03:22]

I will address it as we have discussed offline.

+      CreateVectorIcon(kSystemMenuSmsIcon, kMenuIconSize, kMenuIconColor)));
+
+  std::string notification_id = kNotificationId + std::to_string(message_id_);
+  std::unique_ptr<message_center::Notification> notification;
+  notification.reset(new message_center::Notification(
+      message_center::NOTIFICATION_TYPE_SIMPLE, notification_id,
+      base::ASCIIToUTF16(message_number), base::ASCIIToUTF16(message_text),
+      image, base::string16(), GURL(),
+      message_center::NotifierId(message_center::NotifierId::APPLICATION,
+                                 system_notifier::kNotifierSms),
+      message_center::RichNotificationData(), nullptr));
+  message_center::MessageCenter::Get()->AddNotification(
+      std::move(notification));
+}
+
+}  // namespace ash