Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: ash/common/shelf/shelf_widget.h

Issue 2583393002: Send notification to users upon receiving sms messages (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/shelf/shelf_widget.h
diff --git a/ash/common/shelf/shelf_widget.h b/ash/common/shelf/shelf_widget.h
index 7225ccedaf08850275af592ab04d8e77003a7762..31daf1c60da8e553f81c56d642bbef7887fa691f 100644
--- a/ash/common/shelf/shelf_widget.h
+++ b/ash/common/shelf/shelf_widget.h
@@ -25,10 +25,15 @@ class AppListButton;
class FocusCycler;
class ShelfLayoutManager;
class ShelfView;
+class SmsObserver;
class StatusAreaWidget;
class WmShelf;
class WmWindow;
+namespace test {
+class SmsObserverTest;
+}
+
// The ShelfWidget manages the shelf view (which contains the shelf icons) and
// the status area widget. There is one ShelfWidget per display. It is created
// early during RootWindowController initialization.
@@ -106,6 +111,7 @@ class ASH_EXPORT ShelfWidget : public views::Widget,
private:
class DelegateView;
friend class DelegateView;
+ friend class ash::test::SmsObserverTest;
WmShelf* wm_shelf_;
@@ -122,6 +128,8 @@ class ASH_EXPORT ShelfWidget : public views::Widget,
// at the login screen.
ShelfView* shelf_view_;
ShelfBackgroundAnimator background_animator_;
+ // Owned by ShelfWidget.
tdanderson 2017/02/07 00:15:45 nit: This comment is not needed in this case since
yiyix 2017/02/07 22:03:22 Done.
+ std::unique_ptr<SmsObserver> sms_observer_;
bool activating_as_fallback_;
DISALLOW_COPY_AND_ASSIGN(ShelfWidget);

Powered by Google App Engine
This is Rietveld 408576698